From 77088586445e777a238f245ff96743e0773e49a7 Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Fri, 26 Jul 2019 13:49:17 -0700 Subject: [PATCH] fix(jasmine): enforce that jasmine_node_test is loaded from new location BREAKING CHANGE: You can no longer get jasmine_node_test from @build_bazel_rules_nodejs. - Use `load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")` instead - You need to remove `@npm//jasmine` from the deps of the jasmine_node_test - If you use user-managed dependencies, see the commit for examples of the change needed Also makes the repo bazel-lint-clean, so running yarn bazel:lint-fix no longer makes edits. Fixes #838 --- docs/BUILD.bazel | 1 - docs/common/check_bazel_version.html | 6 - docs/history-server/history_server.html | 6 - docs/http-server/http_server.html | 6 - docs/index.html | 29 - docs/jasmine_node_test/jasmine_node_test.html | 213 ------ docs/node/node.html | 6 - docs/node/node_repositories.html | 6 - docs/npm_install/npm_install.html | 6 - docs/npm_package/npm_package.html | 6 - docs/rollup/rollup_bundle.html | 6 - e2e/define_var/BUILD.bazel | 11 +- e2e/define_var/define.spec.js | 17 +- e2e/define_var/package.json | 5 +- e2e/karma_typescript/BUILD.bazel | 2 +- e2e/karma_typescript/package.json | 1 + e2e/karma_typescript/yarn.lock | 549 ++++++++++++- .../package-lock.json | 6 +- examples/bazel_managed_deps/BUILD.bazel | 2 +- examples/bazel_managed_deps/WORKSPACE | 4 + examples/bazel_managed_deps/package.json | 2 +- examples/bazel_managed_deps/yarn.lock | 718 +++++++++++++++++- examples/parcel/BUILD.bazel | 3 +- examples/parcel/WORKSPACE | 12 + examples/parcel/package-lock.json | 656 ++++++++++++++++ examples/parcel/package.json | 3 +- examples/program/BUILD.bazel | 4 +- examples/program/WORKSPACE | 12 + examples/program/package.json | 3 +- examples/program/yarn.lock | 595 +++++++++++++++ examples/vendored_node/BUILD.bazel | 9 +- examples/vendored_node/WORKSPACE | 12 + examples/vendored_node/npm/package.json | 3 +- examples/vendored_node/yarn/package.json | 3 +- internal/e2e/fine_grained_deps/BUILD.bazel | 11 +- .../e2e/fine_grained_symlinks/BUILD.bazel | 10 +- .../e2e/fine_grained_symlinks/index.spec.js | 7 +- .../e2e/fine_grained_symlinks/package.json | 1 - internal/e2e/fine_grained_symlinks/yarn.lock | 17 +- internal/e2e/node/BUILD.bazel | 5 +- .../BUILD.bazel | 7 +- .../node_loader_test.spec.js | 44 +- .../package.json | 1 - .../yarn.lock | 91 --- .../node_loader_preserve_symlinks/BUILD.bazel | 7 +- .../node_loader_test.spec.js | 44 +- .../package.json | 1 - .../node_loader_preserve_symlinks/yarn.lock | 91 --- internal/e2e/packages/BUILD.bazel | 29 +- internal/e2e/packages/npm_determinism.spec.js | 17 +- internal/e2e/packages/test_version.js | 10 +- .../e2e/packages/yarn_determinism.spec.js | 16 +- internal/e2e/rollup/BUILD.bazel | 6 +- .../e2e/rollup_code_splitting/BUILD.bazel | 7 +- .../e2e/rollup_fine_grained_deps/BUILD.bazel | 4 +- internal/jasmine_node_test/BUILD.bazel | 1 - .../jasmine_node_test/jasmine_node_test.bzl | 32 +- internal/jasmine_node_test/jasmine_runner.js | 101 --- internal/jasmine_node_test/test/BUILD.bazel | 34 - internal/jasmine_node_test/test/foo.spec.js | 5 - internal/jasmine_node_test/test/foo.test.js | 5 - internal/jasmine_node_test/test/foo_spec.js | 5 - internal/jasmine_node_test/test/foo_test.js | 5 - .../jasmine_node_test/test/no_jasmine_test.js | 8 - internal/npm_install/BUILD.bazel | 2 +- internal/npm_install/test/BUILD.bazel | 5 +- internal/npm_package/test/BUILD.bazel | 4 +- internal/npm_package/test/npm_package.spec.js | 11 +- internal/rollup/BUILD.bazel | 3 +- internal/web_package/BUILD.bazel | 11 +- internal/web_package/test/BUILD.bazel | 4 +- internal/web_package/test2/BUILD.bazel | 4 +- packages/jasmine/src/index.from_src.bzl | 7 +- packages/labs/test/webpack/BUILD.bazel | 3 +- 74 files changed, 2711 insertions(+), 888 deletions(-) delete mode 100644 docs/jasmine_node_test/jasmine_node_test.html delete mode 100644 internal/jasmine_node_test/jasmine_runner.js delete mode 100644 internal/jasmine_node_test/test/BUILD.bazel delete mode 100644 internal/jasmine_node_test/test/foo.spec.js delete mode 100644 internal/jasmine_node_test/test/foo.test.js delete mode 100644 internal/jasmine_node_test/test/foo_spec.js delete mode 100644 internal/jasmine_node_test/test/foo_test.js delete mode 100644 internal/jasmine_node_test/test/no_jasmine_test.js diff --git a/docs/BUILD.bazel b/docs/BUILD.bazel index f3d6a35ada..cc05a483a8 100644 --- a/docs/BUILD.bazel +++ b/docs/BUILD.bazel @@ -20,7 +20,6 @@ skylark_doc( "//internal/common:check_bazel_version.bzl", "//internal/history-server:history_server.bzl", "//internal/http-server:http_server.bzl", - "//internal/jasmine_node_test:jasmine_node_test.bzl", "//internal/node:node.bzl", "//internal/node:node_repositories.bzl", "//internal/npm_install:npm_install.bzl", diff --git a/docs/common/check_bazel_version.html b/docs/common/check_bazel_version.html index a85cae8f95..7aeb9a4cc4 100644 --- a/docs/common/check_bazel_version.html +++ b/docs/common/check_bazel_version.html @@ -48,12 +48,6 @@ -
  • - NodeJS testing - -
  • Executing programs