Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@bazel/jasmine 0.38 depends on mem@1.1 which has a security issue #1218

Closed
mprobst opened this issue Oct 1, 2019 · 2 comments · Fixed by #1135
Closed

@bazel/jasmine 0.38 depends on mem@1.1 which has a security issue #1218

mprobst opened this issue Oct 1, 2019 · 2 comments · Fixed by #1135
Labels
cleanup Tech debt, resolving it improves our own velocity

Comments

@mprobst
Copy link
Contributor

mprobst commented Oct 1, 2019

Not sure if this is readable to you:
https://github.com/angular/tsickle/network/alert/yarn.lock/mem/open

WS-2018-0236 More information
moderate severity
Vulnerable versions: < 4.0.0
Patched version: 4.0.0
In nodejs-mem before version 4.0.0 there is a memory leak due to old results not being removed from the cache despite reaching maxAge. Exploitation of this can lead to exhaustion of memory and subsequent denial of service.
$ npm ls mem
tsickle@0.37.0 /usr/local/google/home/martinprobst/src/tsickle
└─┬ @bazel/jasmine@0.38.0
  └─┬ v8-coverage@1.0.9
    └─┬ yargs@11.1.0
      └─┬ os-locale@2.1.0
        └── mem@1.1.0 
@Toxicable
Copy link

I was thinking about this a few days ago and I think we should drop the direct dep on v8-coverage.
This is the only module we need from it: https://github.com/Eywek/v8-coverage/blob/master/src/report.js
Which dosen't have much logic, so wouldn't be hard to migrate.

Doing this would reduce the transative deps we have for coverage but increase at the direct deps we have to include:

  • istanbul-lib-coverage
  • istanbul-lib-reports
  • v8-to-istanbul

@Toxicable
Copy link

I also have this PR where I could make t hose changes: #1135

Will try find some time on an afternoon this week, otherwise this weekend

@Toxicable Toxicable mentioned this issue Oct 12, 2019
4 tasks
@alexeagle alexeagle added the cleanup Tech debt, resolving it improves our own velocity label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants