Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg_npm has outputs attribute which has been deprecated #2387

Closed
EliSchleifer opened this issue Jan 6, 2021 · 1 comment
Closed

pkg_npm has outputs attribute which has been deprecated #2387

EliSchleifer opened this issue Jan 6, 2021 · 1 comment

Comments

@EliSchleifer
Copy link

🐞 bug report

Affected Rule

internal/pkg_npm/pkg_npm.bzl

pkg_npm = rule(
implementation = _pkg_npm,
attrs = PKG_NPM_ATTRS,
doc = _DOC,
outputs = PKG_NPM_OUTPUTS,
)

Is this a regression?

No. New bazel deprecation

Description

outputs were deprecated by bazel and should be removed from this rule

🔬 Minimal Reproduction

Build rules_nodejs with latest bazel

🔥 Exception or Error



ERROR: Traceback (most recent call last):
        File ".../build_bazel_rules_nodejs/internal/node/node.bzl", line 553, column 21, in 
                nodejs_binary = rule(
Error in rule: in call to rule(), parameter 'outputs' is deprecated and will be removed soon. It may be temporarily re-enabled by setting --incompatible_no_rule_outputs_param=false
ERROR: error loading package '': in ...index.bzl: Extension file 'internal/node/node.bzl' has errors
INFO: Elapsed time: 2.639s

🌍 Your Environment

Operating System:

  
OSX Catalina
  

Output of bazel version:

  
Build label: 3.7.2
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Dec 17 17:02:20 2020 (1608224540)
Build timestamp: 1608224540
Build timestamp as int: 1608224540
  

Rules_nodejs version:

(Please check that you have matching versions between WORKSPACE file and @bazel/* npm packages.)

  

  

Anything else relevant?

@mattem
Copy link
Collaborator

mattem commented Jan 7, 2021

Thanks for the report.
This was flagged in #1303, there are some docs issues to resolve as outlined in the upstream bazel issue bazelbuild/bazel#7977 and in Stardoc bazelbuild/stardoc#27

I'm guessing your running with --incompatible_no_rule_outputs_param, unfortunately it will have to be disabled currently --noincompatible_no_rule_outputs_param

I'll close this as duplicate

@mattem mattem closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants