Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jasmine_node_test bazel coverage support #638

Closed
Toxicable opened this issue Mar 29, 2019 · 4 comments
Closed

jasmine_node_test bazel coverage support #638

Toxicable opened this issue Mar 29, 2019 · 4 comments
Labels
blocked Can Close? We will close this in 30 days if there is no further activity enhancement

Comments

@Toxicable
Copy link

🚀 feature request

Relevant Rules

jasmine_node_test

Description

Describe the solution you'd like

Add support for the bazel coverage command

We currently support coverage via the coverage = True flag which outputs a text summary of the coverage collected by that rule. 9abc78f
This however does not merge coverage between targets

The solution is to use the bazel coverage command to aggregate and merge coverage reports from the various targets throughout a repository.

Currently sort of blocked by bazelbuild/bazel#5885
There is no general way to utilise bazel coverage but it is possible to hack around it.

Describe alternatives you've considered

This is the only option for coverage under jasmine throughout a repository

@Toxicable
Copy link
Author

I just found COVERAGE_OUTPUT_FILE which is an env var set by bazel that that tells you were to write coverage files

@Toxicable Toxicable mentioned this issue Sep 18, 2019
4 tasks
@Toxicable
Copy link
Author

Toxicable commented Sep 18, 2019

Another related link.
Looks like each build rule can return a provider for coverage to indicate which files should be instrumented.
https://docs.bazel.build/versions/0.23.0/skylark/rules.html#code-coverage-instrumentation

We should use this instead of parsing through the manifest file to know what files we should collect coverage for

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 90 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Nov 18, 2020
@github-actions
Copy link

github-actions bot commented Dec 2, 2020

This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

@github-actions github-actions bot closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Can Close? We will close this in 30 days if there is no further activity enhancement
Projects
None yet
Development

No branches or pull requests

2 participants