From 4c379d2d7cb1fd0a81b2248a332a618f91e6e4ed Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Tue, 22 Dec 2020 08:00:48 -0800 Subject: [PATCH] fix(builtin): only pass kwargs to the test, not the .update binary This allows you to set things like size or timeout to prevent warnings under bazel test --test_verbose_timeout_warnings --- internal/generated_file_test/generated_file_test.bzl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/generated_file_test/generated_file_test.bzl b/internal/generated_file_test/generated_file_test.bzl index ba3f8fe237..a16a1799ff 100644 --- a/internal/generated_file_test/generated_file_test.bzl +++ b/internal/generated_file_test/generated_file_test.bzl @@ -16,7 +16,7 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg anywhere within the generated file. Note that the .update rule is not generated in substring mode. src_dbg: if the build uses `--compilation_mode dbg` then some rules will produce different output. In this case you can specify what the dbg version of the output should look like - **kwargs: extra arguments passed to the underlying nodejs_test or nodejs_binary + **kwargs: extra arguments passed to the underlying nodejs_test """ data = [src, generated] @@ -46,5 +46,4 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg entry_point = "@build_bazel_rules_nodejs//internal/generated_file_test:bundle.js", templated_args = ["--out", loc % src, loc % src_dbg, loc % generated], data = data, - **kwargs )