From 1f642f105e396e812eaf7577944a12dde5c9d6b2 Mon Sep 17 00:00:00 2001 From: Long Ho Date: Sun, 16 May 2021 20:40:03 -0700 Subject: [PATCH 1/3] fix: make generated_file_test `.update`'s visibility same as test rule --- internal/generated_file_test/generated_file_test.bzl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/internal/generated_file_test/generated_file_test.bzl b/internal/generated_file_test/generated_file_test.bzl index a16a1799ff..4238789b61 100644 --- a/internal/generated_file_test/generated_file_test.bzl +++ b/internal/generated_file_test/generated_file_test.bzl @@ -2,7 +2,7 @@ load("@build_bazel_rules_nodejs//internal/node:node.bzl", "nodejs_binary", "nodejs_test") -def generated_file_test(name, generated, src, substring_search = False, src_dbg = None, **kwargs): +def generated_file_test(name, generated, src, substring_search = False, src_dbg = None, visiblity = None, **kwargs): """Tests that a file generated by Bazel has identical content to a file in the workspace. This is useful for testing, where a "snapshot" or "golden" file is checked in, @@ -36,6 +36,7 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg loc % generated, ], data = data, + visibility = visibility, **kwargs ) @@ -46,4 +47,5 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg entry_point = "@build_bazel_rules_nodejs//internal/generated_file_test:bundle.js", templated_args = ["--out", loc % src, loc % src_dbg, loc % generated], data = data, + visibility = visibility, ) From 30cb1337584c7de861fb6aa1fbdc01397fd28245 Mon Sep 17 00:00:00 2001 From: Long Ho Date: Sun, 16 May 2021 20:42:44 -0700 Subject: [PATCH 2/3] fix typo --- internal/generated_file_test/generated_file_test.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/generated_file_test/generated_file_test.bzl b/internal/generated_file_test/generated_file_test.bzl index 4238789b61..08acd254c2 100644 --- a/internal/generated_file_test/generated_file_test.bzl +++ b/internal/generated_file_test/generated_file_test.bzl @@ -2,7 +2,7 @@ load("@build_bazel_rules_nodejs//internal/node:node.bzl", "nodejs_binary", "nodejs_test") -def generated_file_test(name, generated, src, substring_search = False, src_dbg = None, visiblity = None, **kwargs): +def generated_file_test(name, generated, src, substring_search = False, src_dbg = None, visibility = None, **kwargs): """Tests that a file generated by Bazel has identical content to a file in the workspace. This is useful for testing, where a "snapshot" or "golden" file is checked in, From 34fae68b6e3cddc165958ee0af9b29954ec97a0e Mon Sep 17 00:00:00 2001 From: Long Ho Date: Sun, 16 May 2021 20:43:16 -0700 Subject: [PATCH 3/3] update docs --- internal/generated_file_test/generated_file_test.bzl | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/generated_file_test/generated_file_test.bzl b/internal/generated_file_test/generated_file_test.bzl index 08acd254c2..d0d63e7620 100644 --- a/internal/generated_file_test/generated_file_test.bzl +++ b/internal/generated_file_test/generated_file_test.bzl @@ -16,6 +16,7 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg anywhere within the generated file. Note that the .update rule is not generated in substring mode. src_dbg: if the build uses `--compilation_mode dbg` then some rules will produce different output. In this case you can specify what the dbg version of the output should look like + visibility: visibility for both test target & update target **kwargs: extra arguments passed to the underlying nodejs_test """ data = [src, generated]