Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing repository for oci_push in from a file #338

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

mboulton-fathom
Copy link
Contributor

As mentioned in the updated docs this is useful if you want to push to a different repository (eg, separate dev/prod repositories) based on a stamp variable.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this feature makes sense.

Ideally we'd only have the repository_file attribute on the rule, but that would be a breaking change so I think we do need both now.

examples/push/BUILD.bazel Show resolved Hide resolved
oci/private/push.sh.tpl Show resolved Hide resolved
@alexeagle alexeagle merged commit 2425844 into bazel-contrib:main Sep 14, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants