Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Azure Container Registry oci_pull support #340

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

HDYA
Copy link
Contributor

@HDYA HDYA commented Aug 24, 2023

  • update how _WWW_AUTH is used to match registry
    • use placeholder {registry} in field realm and service
    • also check for suffix match
  • update how authentication response is handled
    • check for field access_token
    • fail if no token found

@HDYA HDYA changed the title feat: add ACR support feat: add ACR oci_pull support Aug 24, 2023
@HDYA HDYA changed the title feat: add ACR oci_pull support feat: add Azure Container Registry oci_pull support Aug 24, 2023
oci/private/pull.bzl Outdated Show resolved Hide resolved
@thesayyn thesayyn merged commit fd45335 into bazel-contrib:main Sep 14, 2023
15 checks passed
@HDYA HDYA deleted the hdya/acr-support branch September 18, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants