Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an example jekyll site #74

Merged
merged 4 commits into from
Feb 11, 2024
Merged

Conversation

RyanDraves
Copy link
Contributor

Add files for making an example Jekyll site with rules_ruby. Also adds a CI job for testing that it builds.

@p0deje
Copy link
Member

p0deje commented Feb 5, 2024

There are some failures on CI, I think macOS would be trivial to fix, while Windows looks more complicated. WOuld you mind taking a look?

@RyanDraves
Copy link
Contributor Author

There are some failures on CI, I think macOS would be trivial to fix, while Windows looks more complicated. WOuld you mind taking a look?

I believe I fixed up the Mac build. Do you mind if I remove Windows support for this example? I didn't find anything useful when searching for the error and have no Windows development experience.

@p0deje
Copy link
Member

p0deje commented Feb 6, 2024

I believe I fixed up the Mac build. Do you mind if I remove Windows support for this example? I didn't find anything useful when searching for the error and have no Windows development experience.

Yes, let's remove for now.

Copy link
Member

@p0deje p0deje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I left one small comment about a symlink, otherwise will merge it.

examples/jekyll/bazel-jekyll Outdated Show resolved Hide resolved
@p0deje p0deje merged commit 247e2a3 into bazel-contrib:main Feb 11, 2024
43 checks passed
@RyanDraves RyanDraves deleted the jekyll_example branch March 3, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants