feat(coverage): Basic test coverage support #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit lays the foundation for displaying coverage results from `bazel coverage`. For the time being, the functionality is only exposed through the user-defined tasks in the `tasks.json`. It is thereby a bit hard to discover. But this is fine for the time being, because coverage still has a couple of rough edges anyway. As soon as it is more stable, we should add builtin commands and expose coverage runs also in the "Bazel Build Target" tree. Changes in this commit: * Bumps the VS Code version to 1.88, i.e. the first VS Code version which supports the test coverage API. * Upgrades to ES2022. I wanted to use `replaceAll` which was introduced in ES2021. VS Code 1.88 is based on Node 18 which in turn is based on V8 10.1. V8 10.18 supports ECMA-262 also known as ES2023. However, ES2023 is not yet available a target language in the `tsconfig.json`. Furthermore, Firefox does not fully support ES2023, yet. While web browsers are currently not relevant, they might become so in the future if we want to turn this into a browser-enabled VSCode extension. An upgrade to ES2021 would have been sufficient, but I went directly to ES2022 because it might some of the other new features might also turn out useful. * Introduces a custom LCOV parser. I could not find any other high-quality open-source parser. E.g., most other parser don't properly parse function names with `:` and / or `,` in them. * Introduces test cases for that custom LCOV parser. Future work: * Support for branch coverage * Demangling of function names * Builtin commands to trigger coverage runs & offer them in the "Bazel Build Tree" Tested with: Java, C++, Go, Rust Untested: Python, Swift, Kotlin, Scala and many more This is the first step towards bazel-contrib#362
vogelsgesang
requested review from
coeuvre,
jfirebaugh and
cameron-martin
as code owners
|
See microsoft/vscode#209697 for a couple of screenshots |
vogelsgesang
changed the title
Closed
|
I've reviewed everything but the lcov parser, and it looks good. I've run out of time this evening, so I'll have to review the lcov parser another day. |
|
I am still interested in merging this, but I will wait with resolving the merge conflicts until after the review 🙂 |
cameron-martin
approved these changes
Apr 30, 2024
|
No worries, I know this was a larger, more complicated commit. Thanks for taking the time to review this in-depth instead of just give me a "probably good-enough approval"! Good reviews are important to the project in the long run 🙂 |
vogelsgesang
added a commit
to vogelsgesang/vscode-bazel
that referenced
this pull request
May 2, 2024
During the rebase of bazel-contrib#366, I accidentally duplicated the `test` key inside the `scripts` in `package.json`. There was no warning whatsoever and CI was still green, but didn't actually run the `vscode-test` tests. This commit fixes the mishap
This was referenced May 2, 2024
Merged
cameron-martin
added a commit
that referenced
this pull request
May 2, 2024
During the rebase of #366, I accidentally duplicated the `test` key inside the `scripts` in `package.json`. There was no warning whatsoever and CI was still green, but didn't actually run the `vscode-test` tests. This commit fixes the mishap Co-authored-by: Cameron Martin <cameronmartin123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit lays the foundation for displaying coverage results from
bazel coverage.Currently, the functionality is only exposed through the user-defined tasks in the
tasks.json. It is thereby a bit hard to discover. But this is fine for the time being, because coverage still has a couple of rough edges anyway. As soon as it is more stable, we should add builtin commands and expose coverage runs also in the "Bazel Build Target" tree.Changes in this commit:
replaceAllwhich was introduced in ES2021. VS Code 1.88 is based on Node 18 which in turn is based on V8 10.1. V8 10.18 supports ECMA-262 also known as ES2023. However, ES2023 is not yet available a target language in thetsconfig.json. Furthermore, Firefox does not fully support ES2023, yet. While web browsers are currently not relevant, they might become so in the future if we want to turn this into a browser-enabled VSCode extension. An upgrade to ES2021 would have been sufficient, but I went directly to ES2022 because it might some of the other new features might also turn out useful.:and / or,in them.Future work:
Tested with: Java, C++, Go, Rust
Untested: Python, Swift, Kotlin, Scala and many more
This is the first step towards #362