Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wanted: google/benchmark #384

Closed
1 task
jsharpe opened this issue Jan 18, 2023 · 4 comments
Closed
1 task

wanted: google/benchmark #384

jsharpe opened this issue Jan 18, 2023 · 4 comments
Labels
module wanted Users want a certain module to be available in the BCR, contributions are welcome!

Comments

@jsharpe
Copy link
Contributor

jsharpe commented Jan 18, 2023

Module location

https://github.com/google/benchmark

Link to bzlmod issue in the module's repository

No response

Any other context to provide?

No response

Fund our work

  • Sponsor our community's open source work by donating a feature bounty
@jsharpe jsharpe added the module wanted Users want a certain module to be available in the BCR, contributions are welcome! label Jan 18, 2023
@macandy13
Copy link
Contributor

I started the migration of this module to bzlmod, please get in touch if you are about to do the same.

@macandy13
Copy link
Contributor

Quick update on the progress: The C++ parts of the google-benchmark library have been fully migrated to bzlmod, but the Python bindings part is still pending. The reason is that for it to be properly done, some prework in python_rules (bazelbuild/rules_python#824) need to happen (mainly a way to detect the current Python toolchain in a target to select the right Python headers).

@macandy13
Copy link
Contributor

Clarification to my comment above: In order to depend on google/benchmark using blzmod (in a C++ project), everything should be in place now.

The Python bindings migration is needed to build the pywheel packages for google-benchmark, so it is more of an internal TODO than a necessity in my opinion.

@mmorel-35
Copy link
Contributor

Hi @jsharpe ,
I believe this can be closed with https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/google_benchmark ?

@jsharpe jsharpe closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module wanted Users want a certain module to be available in the BCR, contributions are welcome!
Projects
None yet
Development

No branches or pull requests

3 participants