From caf2bc1ae197aea45aee80c2fd8845937097f00a Mon Sep 17 00:00:00 2001 From: Xavier Bonaventura Date: Tue, 16 May 2023 05:40:08 +0200 Subject: [PATCH] Build with incompatible_disallow_empty_glob (#447) In order to flip the flag, all downstream projects should be adapted. However, it is hard to fix them all if there are constant regressions. Adding it to the CI will ensure that once the project can build with incompatible_disallow_empty_glob it can keep building like that. See: bazelbuild/bazel#15327 --- .bazelci/presubmit.yml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index aabe02a4..5e83f46c 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -15,6 +15,8 @@ tasks: name: "Latest Bazel" platform: ubuntu1804 bazel: latest + build_flags: + - "--incompatible_disallow_empty_glob" test_flags: - "--test_env=PATH" @@ -23,6 +25,8 @@ tasks: name: "Latest Bazel" platform: ubuntu1604 bazel: latest + build_flags: + - "--incompatible_disallow_empty_glob" test_flags: - "--test_env=PATH" @@ -31,6 +35,8 @@ tasks: name: "Latest Bazel" platform: macos bazel: latest + build_flags: + - "--incompatible_disallow_empty_glob" test_flags: - "--test_env=PATH" @@ -39,6 +45,8 @@ tasks: name: "Latest Bazel" platform: windows bazel: latest + build_flags: + - "--incompatible_disallow_empty_glob" test_flags: # TODO(laszlocsomor): remove "--test_env=LOCALAPPDATA" after # https://github.com/bazelbuild/bazel/issues/7761 is fixed @@ -50,6 +58,8 @@ tasks: name: "Last Green Bazel" platform: ubuntu1804 bazel: last_green + build_flags: + - "--incompatible_disallow_empty_glob" test_flags: - "--test_env=PATH" @@ -58,6 +68,8 @@ tasks: name: "Last Green Bazel" platform: ubuntu1604 bazel: last_green + build_flags: + - "--incompatible_disallow_empty_glob" test_flags: - "--test_env=PATH" @@ -66,6 +78,8 @@ tasks: name: "Last Green Bazel" platform: macos bazel: last_green + build_flags: + - "--incompatible_disallow_empty_glob" test_flags: - "--test_env=PATH" @@ -74,6 +88,8 @@ tasks: name: "Last Green Bazel" platform: windows bazel: last_green + build_flags: + - "--incompatible_disallow_empty_glob" test_flags: # TODO(laszlocsomor): remove "--test_env=LOCALAPPDATA" after # https://github.com/bazelbuild/bazel/issues/7761 is fixed @@ -86,6 +102,7 @@ tasks: platform: ubuntu1804 bazel: last_green build_flags: + - "--incompatible_disallow_empty_glob" - "--experimental_enable_bzlmod" test_flags: - "--experimental_enable_bzlmod"