Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stamp in run_binary #541

Open
tpudlik opened this issue Sep 17, 2024 · 0 comments
Open

Support stamp in run_binary #541

tpudlik opened this issue Sep 17, 2024 · 0 comments

Comments

@tpudlik
Copy link
Contributor

tpudlik commented Sep 17, 2024

It's common to use genrule with stamp = -1 to integrate the workspace status (git hash or timestamp) into binaries. (This is not well documented, but see bazelbuild/bazel#4942.) However, genrule is not cross-platform; folks should really be using run_binary instead of genrule wherever they can. Unfortunately, run_binary doesn't have the stamp attribute!

The FR is to add that support.

BTW, the bazel-lib fork of run_binary does support stamp = -1 bazel-contrib/bazel-lib#185. I'm not sure if the fork is close enough for the support to be easy to upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant