From 360fd6267675825a9187038d2ff92d8b32147ab8 Mon Sep 17 00:00:00 2001 From: Justin Horvitz Date: Thu, 7 Dec 2023 05:24:34 -0800 Subject: [PATCH] Re-enable minimal_jdk_test with a higher tolerance Re-enable `minimal_jdk_test` with a higher tolerance. Closes #20451. PiperOrigin-RevId: 588756736 Change-Id: Ib26da4a31f942b1f0d7a3ed976389449f7995105 --- .bazelci/postsubmit.yml | 2 -- .bazelci/presubmit.yml | 1 - src/test/shell/integration/minimal_jdk_test.sh | 6 +++--- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.bazelci/postsubmit.yml b/.bazelci/postsubmit.yml index 43eed4a8b4c29e..ceb5eed0de0172 100644 --- a/.bazelci/postsubmit.yml +++ b/.bazelci/postsubmit.yml @@ -227,7 +227,6 @@ tasks: - "-//src/test/java/com/google/devtools/build/lib/rules/objc:ObjcRulesTests" - "-//src/test/java/com/google/devtools/build/lib/rules/objc:BazelJ2ObjcLibraryTest" - "-//src/test/java/com/google/devtools/build/lib/rules/cpp:CcToolchainTest" - - "-//src/test/shell/integration:minimal_jdk_test" include_json_profile: - build - test @@ -293,7 +292,6 @@ tasks: - "-//src/test/java/com/google/devtools/build/lib/rules/objc:ObjcRulesTests" - "-//src/test/java/com/google/devtools/build/lib/rules/objc:BazelJ2ObjcLibraryTest" - "-//src/test/java/com/google/devtools/build/lib/rules/cpp:CcToolchainTest" - - "-//src/test/shell/integration:minimal_jdk_test" include_json_profile: - build - test diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index b799df7ddb2cfc..96917e1468d985 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -231,7 +231,6 @@ tasks: - "-//src/test/java/com/google/devtools/build/lib/rules/objc:ObjcRulesTests" - "-//src/test/java/com/google/devtools/build/lib/rules/objc:BazelJ2ObjcLibraryTest" - "-//src/test/java/com/google/devtools/build/lib/rules/cpp:CcToolchainTest" - - "-//src/test/shell/integration:minimal_jdk_test" include_json_profile: - build - test diff --git a/src/test/shell/integration/minimal_jdk_test.sh b/src/test/shell/integration/minimal_jdk_test.sh index 82f40fd9e63a94..dad2abe4aa6e64 100755 --- a/src/test/shell/integration/minimal_jdk_test.sh +++ b/src/test/shell/integration/minimal_jdk_test.sh @@ -42,13 +42,13 @@ export BAZEL_SUFFIX="_jdk_minimal" source "$(rlocation "io_bazel/src/test/shell/integration_test_setup.sh")" \ || { echo "integration_test_setup.sh not found!" >&2; exit 1; } -# Bazel's install base is < 370MB with minimal JDK and > 370MB with an all +# Bazel's install base is < 450MB with minimal JDK and > 450MB with an all # modules JDK. -function test_size_less_than_370MB() { +function test_size_less_than_450MB() { bazel info ib=$(bazel info install_base) size=$(du -s "$ib" | cut -d\ -f1) - maxsize=$((1024*370)) + maxsize=$((1024*450)) if [ $size -gt $maxsize ]; then echo "$ib was too big:" 1>&2 du -a "$ib" 1>&2