From 5ab5d80e08bd42b056403c12f2d1f7be4996e3d4 Mon Sep 17 00:00:00 2001 From: Richard Levasseur Date: Tue, 11 Apr 2023 14:51:37 -0700 Subject: [PATCH] python: Remove mention of defunct --python_binary flag This flag has been removed from the Google build, so don't mention it in the comment as a concern. PiperOrigin-RevId: 523510796 Change-Id: I4622296895b099ec02bc04adae9ebcdf6b036910 --- .../builtins_bzl/common/python/py_executable.bzl | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/main/starlark/builtins_bzl/common/python/py_executable.bzl b/src/main/starlark/builtins_bzl/common/python/py_executable.bzl index 8b7e26e3eae49f..4886dce1cd600b 100644 --- a/src/main/starlark/builtins_bzl/common/python/py_executable.bzl +++ b/src/main/starlark/builtins_bzl/common/python/py_executable.bzl @@ -214,19 +214,13 @@ def _get_runtime_details(ctx, semantics): A struct; see inline-field comments of the return value for details. """ - # NOTE: Both Bazel and Google have similar legacy "path to a python - # interpreter" flags with similar functions, but with subtle differences. - # # Bazel has --python_path. This flag has a computed default of "python" when # its actual default is null (see # BazelPythonConfiguration.java#getPythonPath). This flag is only used if - # toolchains are not enabled and `--python_top` isn't set. - # - # Google has --python_binary. This flag defaults to null; no special - # computed behavior. If set, it is used instead of any runtime or toolchain. - # This is a legacy behavior, but not fully cleaned up yet. + # toolchains are not enabled and `--python_top` isn't set. Note that Google + # used to have a variant of this named --python_binary, but it has since + # been removed. # - # TODO(b/230428071): Remove this once Google's --python_binary flag is removed. # TOOD(bazelbuild/bazel#7901): Remove this once --python_path flag is removed. if IS_BAZEL: