From 6269ca7d0713743cc83924a0333e874596f0a137 Mon Sep 17 00:00:00 2001 From: mschaller Date: Wed, 16 Jan 2019 13:13:41 -0800 Subject: [PATCH] Note that {CreateInc,Solib}SymlinkAction may insensitively propagate inputs If re-executed, these actions will not recreate an output which a downstream action discovered was lost. Rewinding must traverse across these actions and their artifacts to reach the actions whose re-execution will recreate such a lost output. RELNOTES: None. PiperOrigin-RevId: 229612553 --- .../devtools/build/lib/rules/cpp/CreateIncSymlinkAction.java | 5 +++++ .../devtools/build/lib/rules/cpp/SolibSymlinkAction.java | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CreateIncSymlinkAction.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CreateIncSymlinkAction.java index 22d0a17d5a681b..b006593f8a4d8f 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CreateIncSymlinkAction.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CreateIncSymlinkAction.java @@ -100,5 +100,10 @@ protected String getRawProgressMessage() { public String getMnemonic() { return "Symlink"; } + + @Override + public boolean mayInsensitivelyPropagateInputs() { + return true; + } } diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/SolibSymlinkAction.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/SolibSymlinkAction.java index d1419f3c90a45e..c685dde3ddbd8a 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/SolibSymlinkAction.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/SolibSymlinkAction.java @@ -228,4 +228,9 @@ public static String getDynamicLibrarySoname(PathFragment libraryPath, public boolean shouldReportPathPrefixConflict(ActionAnalysisMetadata action) { return false; // Always ignore path prefix conflict for the SolibSymlinkAction. } + + @Override + public boolean mayInsensitivelyPropagateInputs() { + return true; + } }