From 7e3f2f809492e185abe8ca1cce8f1a0bb10039f4 Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Tue, 14 Feb 2023 13:10:44 -0800 Subject: [PATCH] Remove default -s flag from macOS libtool invocation -s is the default but it's not supported by llvm's libtool replacement which results in failed links. I don't think we really care about the specifics here, so since it's the default for most folks we can drop it. --- .../google/devtools/build/lib/rules/cpp/CppActionConfigs.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppActionConfigs.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppActionConfigs.java index dbe4db4ee261e5..78265b56a5365d 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppActionConfigs.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppActionConfigs.java @@ -611,7 +611,7 @@ public static ImmutableList getLegacyFeatures( " action: 'c++-link-static-library'", " flag_group {", ifLinux(platform, "flag: 'rcsD'"), - ifMac(platform, "flag: '-static'", "flag: '-s'"), + ifMac(platform, "flag: '-static'"), " }", " flag_group {", " expand_if_all_available: 'output_execpath'",