From 9ac7e7109d2a206bcbe27ba43d45abe4691fb94f Mon Sep 17 00:00:00 2001 From: Xavier Bonaventura Date: Sat, 27 Aug 2022 02:38:46 -0700 Subject: [PATCH] Use True instead of 1 in the documentation The parameter is a boolean and because of that True can also be used. From readibility point of view, it is better to use True to know that this is a boolean value and cannot be any arbitrary integer. Having 1 in the documentation makes the users also to use 1 instead of True, that is why the proposal to change it here. Closes #16165. PiperOrigin-RevId: 470425949 Change-Id: I68a776a684d0625571970587a19f0148ebbee79c --- .../devtools/build/lib/rules/genrule/GenRuleBaseRule.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/google/devtools/build/lib/rules/genrule/GenRuleBaseRule.java b/src/main/java/com/google/devtools/build/lib/rules/genrule/GenRuleBaseRule.java index dccac0acfac18b..3da718b93ae4d4 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/genrule/GenRuleBaseRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/genrule/GenRuleBaseRule.java @@ -246,7 +246,7 @@ expanded to Windows style paths (with backslash). /*

- If set to 1, this option causes output files to be written into the bin + If set to True, this option causes output files to be written into the bin directory instead of the genfiles directory.

*/ @@ -259,7 +259,7 @@ expanded to Windows style paths (with backslash). /*

- If set to 1, this option forces this genrule to run using the "local" + If set to True, this option forces this genrule to run using the "local" strategy, which means no remote execution, no sandboxing, no persistent workers.