diff --git a/src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java b/src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java index 63b3059bf04896..912d0264ec0820 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java +++ b/src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java @@ -666,8 +666,8 @@ private String computeRuleKey(Rule rule, StarlarkSemantics starlarkSemantics) { return new Fingerprint() .addBytes(RuleFormatter.serializeRule(rule).build().toByteArray()) .addInt(MARKER_FILE_VERSION) - // TODO: Using the hashCode() method for StarlarkSemantics here is technically wrong. - // hashCode() is not guaranteed to be stable across JVM restarts. + // TODO: Using the hashCode() method for StarlarkSemantics here is suboptimal as + // it doesn't include any default values. .addInt(starlarkSemantics.hashCode()) .hexDigestAndReset(); }