Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add a cc_inputs attribute to *c_library rules #10107

Closed
ob opened this issue Oct 25, 2019 · 2 comments
Closed

Please add a cc_inputs attribute to *c_library rules #10107

ob opened this issue Oct 25, 2019 · 2 comments
Assignees
@oquenchil
Labels
P2 We'll consider working on this in future. (Assignee optional) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: feature request

Comments

@ob
Copy link
Contributor

ob commented Oct 25, 2019

rules_swift's swift_library rule, includes a swiftc_inputs attribute that allows it to pass additional inputs to the invocation of the swiftc compiler. It would be really handy if objc_library(), cc_library(), etc also had this attribute.

The specific use case that I'm thinking of is passing around the module map in cases where it's needed to support @import statements in Objective-C. Currently I'm passing it as a header but this feels hacky.
@ob ob mentioned this issue Oct 25, 2019
Closed
@irengrig irengrig added z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple untriaged type: feature request labels Oct 28, 2019
@ob
Copy link
Contributor Author

ob commented Oct 30, 2019

@irengrig I don't think this is team-Apple, probably more team-Rules-CPP

@jmmv jmmv added team-Rules-CPP Issues for C++ rules and removed z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple labels Oct 31, 2019
@scentini scentini added P2 We'll consider working on this in future. (Assignee optional) and removed team-Rules-CPP Issues for C++ rules untriaged labels Dec 2, 2019
@jin jin added the team-Rules-CPP Issues for C++ rules label Feb 1, 2021
@sgowroji sgowroji added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 13, 2023
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

@oquenchil oquenchil closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oquenchil oquenchil

Labels
P2 We'll consider working on this in future. (Assignee optional) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ob @jin @jmmv @irengrig @scentini @oquenchil @sgowroji