-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow rules_cc to include headers with any file extension #10552
Comments
This keeps being a pain point for users. We should evaluate where our code would break if we just let any header extensions since some logic internally decides one code path or the other based on extension. |
Or maybe just open it up to anything and if the extension is unrecognized then treat it in the same way we treat a .h file. |
I think this problem needs to be solved. |
This will fix #6578 once |
I'm building |
Another one here. Our product auto-generates some C++ headers and files, and we use extensions to differentiate between auto-generated and handwritten code and headers. |
Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team ( |
This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team ( |
@bazelbuild/triage please reopen |
I was considering going down the path of a PR that would use something at the level of command line to (effectively) extend the Another thought was to have it declared in the toolchain config. Is there an appetite for either of these approaches? One more than the other? |
Description of the problem / feature request:
Custom file extensions for rules_cc
Feature requests: what underlying problem are you trying to solve with this feature?
Importing headers such as
foo.bar
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
I have a cc file which has a non-standard include file extension:
How do you include this in a cc_library?
This just throws an error:
To me this looks like it might be hardcoded and there isn't a way to easily add new file extensions:
https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCppRuleClasses.java#L73
What operating system are you running Bazel on?
Arch
What's the output of
bazel info release
?release 2.0.0
Have you found anything relevant by searching the web?
#164
The text was updated successfully, but these errors were encountered: