Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning that STARLARK_SEMANTICS changed #12569

Closed
sjoerdvisscher opened this issue Nov 26, 2020 · 5 comments
Closed

Add a warning that STARLARK_SEMANTICS changed #12569

sjoerdvisscher opened this issue Nov 26, 2020 · 5 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Starlark-Integration Issues involving Bazel's integration with Starlark, excluding builtin symbols type: feature request

Comments

@sjoerdvisscher
Copy link

sjoerdvisscher commented Nov 26, 2020

Bazel was pretty slow for us, seemingly randomly refetching external dependencies. After we finally found a way to reproduce this, we found that in the marker files of the refetched external dependencies the value of STARLARK_SEMANTICS changed. It turns out that we had build --experimental_allow_tags_propagation in our .bazelrc file, which should have been common --experimental_allow_tags_propagation. So every time we did a bazel query or bazel info, and then bazel build, external dependencies were refetched.

It would be nice if bazel would issue a warning saying that the Starlark semantics changed, and ideally mentioning the cause (change of --experimental_allow_tags_propagation in our case), just like it does for discarding the analysis cache.

@aiuto aiuto added team-Configurability platforms, toolchains, cquery, select(), config transitions untriaged team-Starlark and removed team-Configurability platforms, toolchains, cquery, select(), config transitions labels Nov 30, 2020
@brandjon
Copy link
Member

Wow, that's actually a pretty compelling reason for the warning. I can imagine a lot of users getting tripped up over the same thing.

@brandjon brandjon added P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Build-Language type: feature request and removed team-Starlark untriaged labels Feb 19, 2021
@laurentlb
Copy link
Contributor

See also: #10961

This is a very common source of problems.

@mikasun7
Copy link

same issue here.

@brandjon brandjon added team-Starlark-Integration Issues involving Bazel's integration with Starlark, excluding builtin symbols and removed team-Build-Language labels Nov 4, 2022
Copy link

github-actions bot commented Jan 9, 2024

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jan 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please post @bazelbuild/triage in a comment here and we'll take a look. Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Starlark-Integration Issues involving Bazel's integration with Starlark, excluding builtin symbols type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants