Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional linker outputs in cc_binaries #14189

Closed
gholms opened this issue Oct 28, 2021 · 2 comments
Closed

Additional linker outputs in cc_binaries #14189

gholms opened this issue Oct 28, 2021 · 2 comments
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: feature request

Comments

@gholms
Copy link
Contributor

gholms commented Oct 28, 2021

Description of the problem / feature request:

cc_common.link has an additional_outputs arg one can use to obtain extra outputs generated by linkopts. The cc_binary rule ought to have a means of using that so one doesn't need to write a custom version of cc_binary to make use of it.

Feature requests: what underlying problem are you trying to solve with this feature?

I want to be able to generate linkmap files for cc_binary targets like I can with objc's generate_linkmap feature.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Add -Wl,-Map=$(execpath foo.map) to linkopts and observe the map file not making it out of sandboxes or remote executors.

What operating system are you running Bazel on?

Ubuntu

What's the output of bazel info release?

release 4.2.1-1.2 (We have backported some patches from Bazel 5)

If bazel info release returns "development version" or "(@non-git)", tell us how you built Bazel.

bazel build --embed_label 4.2.1-1.2 --stamp -c opt //scripts/packages/debian:bazel-debian

What's the output of git remote get-url origin ; git rev-parse master ; git rev-parse HEAD ?

We have our own git repository that tracks the release branches here and contains things like bugfixes and minor backports.

Have you found anything relevant by searching the web?

Bits and pieces about this for objc binaries, but nothing apart from the cc_common.link arg.

Any other information, logs, or outputs that you want to share?

Nope, but feel free to ask for info if needed!

@oquenchil oquenchil added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Rules-CPP Issues for C++ rules type: feature request labels Nov 2, 2021
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label May 25, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Development

No branches or pull requests

2 participants