Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.2 - April 2022 #15210

Closed
6 tasks done
ckolli5 opened this issue Apr 11, 2022 · 11 comments
Closed
6 tasks done

Release 5.2 - April 2022 #15210

ckolli5 opened this issue Apr 11, 2022 · 11 comments
Assignees
Labels
P1 I'll work on this now. (Assignee required) release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process

Comments

@ckolli5
Copy link

ckolli5 commented Apr 11, 2022

Status of Bazel 5.2

To report a release-blocking bug, please add a comment with the text @bazel-io flag to the issue. A release manager will triage it and add it to the milestone.

To cherry-pick a mainline commit into 5.2, simply send a PR against the release-5.2.0 branch.

Task list:

@ckolli5 ckolli5 added P1 I'll work on this now. (Assignee required) type: process release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Apr 11, 2022
@Wyverald Wyverald pinned this issue Apr 11, 2022
@foxandi
Copy link
Contributor

foxandi commented Apr 25, 2022

Is it possible to get #15306 into this release and have an updated/regenerated embedded JDK for Windows? If yes, I will create a PR with the change against the release branch.

@Wyverald
Copy link
Member

Should be possible. I'm not entirely sure what updating the embedded JDK entails; @hvadehra @comius to comment

@foxandi
Copy link
Contributor

foxandi commented Apr 26, 2022

Thanks :) I created the PR: #15342

@linzhp
Copy link
Contributor

linzhp commented Apr 26, 2022

Can you also include #15341?

@AustinSchuh
Copy link
Contributor

I'm unable to run our tests on a remote execution cluster with 5.2.

The description from @TLATER on the following ticket describes exactly the symptoms I'm seeing, and reverting the patch he mentions fixes it for me. #12821 Can we get 0080572 reverted, or the C++ rules fixed?

@nkoroste
Copy link
Contributor

nkoroste commented May 4, 2022

@nkoroste
Copy link
Contributor

nkoroste commented May 4, 2022

Can we also include:

  1. 1db39e0
  2. Add target label to SpawnExec in the execution log #14818

It adds target label to SpawnExec in the execution log that helps with debugging.

@AustinSchuh
Copy link
Contributor

I'm still unable to run our tests with bazel 5.2.0rc1, which is blocking us from upgrading from bazel 5.0. This looks like a regression in how cc_test, external repositories, and remote execution interact. The suggested fix in to add linkstatic = 1 to every cc_test, which is an incompatible change. The discussion on #12821 has stalled. Reverting 0080572 continues to fix the problem. Could we get a revert cherry-picked, or the C++ rules fixed?

@ckolli5
Copy link
Author

ckolli5 commented Jun 7, 2022

5.2 is now out!

@vbatts @petemounce @excitoon Could you please update relevant package managers? Thanks!

@Wyverald
Copy link
Member

@ckolli5 could you update the release page to point to the release notes blog post? (see last item in the checklist at the top of this page) Then this issue can be closed.

@ckolli5 ckolli5 closed this as completed Jun 13, 2022
@Mizux
Copy link

Mizux commented Jun 13, 2022

Concerning Fedora:latest aka 36, there is currently compilation issue please take a look at:

note: At Bazel Team Googlers / Fedora Community, few words from vbatts:

also, yes I need to hand over maintainership on the fedora builds

ref: vbatts/copr-build-bazel#18 (comment)

@Wyverald Wyverald unpinned this issue Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process
Projects
None yet
Development

No branches or pull requests

8 participants