Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: upgrade rule() code samples from deprecated outputs attribute #15643

Open
gregestren opened this issue Jun 8, 2022 · 0 comments
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts type: documentation (cleanup)

Comments

@gregestren
Copy link
Contributor

gregestren commented Jun 8, 2022

Description of the bug:

Code samples from https://bazel.build/rules/rules#using_the_validations_output_group include

rule_with_validation = rule(
  implementation = _rule_with_validation_impl,
  outputs = {
...

but according to https://bazel.build/rules/lib/globals#rule, output is deprecated and is disabled with -incompatible_no_rule_outputs_param.

Also for This parameter has been deprecated. Migrate rules to use OutputGroupInfo or attr.output instead., let's link to further details / examples.

Let's have doc examples use current best practices.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

#7977

Any other information, logs, or outputs that you want to share?

No response

@gregestren gregestren changed the title Documentation: upgrade rule() code samples from deprecate outputs attribute Documentation: upgrade rule() code samples from deprecated outputs attribute Jun 8, 2022
@sgowroji sgowroji added type: documentation (cleanup) untriaged team-Documentation Documentation improvements that cannot be directly linked to other team labels labels Jun 9, 2022
@sgowroji sgowroji added the team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts label Nov 22, 2022
@keertk keertk added help wanted Someone outside the Bazel team could own this and removed untriaged labels Jan 9, 2023
@comius comius added the P3 We're not considering working on this, but happy to review a PR. (No assignee) label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts type: documentation (cleanup)
Projects
None yet
Development

No branches or pull requests

4 participants