Invalid bzlmod overrides are ignored

[keith]

If you have some archive_override in your MODULE.bazel file that attempts to override a repository that doesn't exist, bazel silently ignores it. I think ideally bazel would error in this case, since it likely points to you trying to override something that you're not pulling in at all.

[sgowroji]

Hello @keith, Could you please provide minimal steps to reproduce the above issue. Thanks!

[keith]

Yea the repro case is if you have a MODULE.bazel with:

archive_override(
    integrity = "sha256-+T69g/MobVF0j4bpoOToa6eQqinQULa6w6dqhymuEjc=",
    module_name = "foo",
    strip_prefix = "apple_support-441103ea05ffbde2da9f77252e27e4f519e01c72",
    urls = [
        "https://github.com/bazelbuild/apple_support/archive/441103ea05ffbde2da9f77252e27e4f519e01c72.tar.gz",
    ],
)

and you have a BUILD file with:

cc_library(name = "main", srcs = ["main.c"])

and main.c is:

int main() { return 0; }

building with bazel build main --enable_bzlmod will work, where I think it should potentially fail because we're trying to override foo which doesn't exist. I'm not sure if all the info available to do this exists, but since it's less lazy than the WORKSPACE I assume it might be possible

[Wyverald]

This should be easy to check. A line around https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BazelModuleResolutionFunction.java;l=85;drc=9860051afe7ccf0902f1ce3dbbc9066088d7c849 should suffice. PRs welcome :)

[github-actions]

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 30 days. It will be closed in the next 7 days unless any other activity occurs or the "not stale" label is added.

[brentleyjones]

@keertk not stale, triaged and not waiting for input

[yokeshwaran1]

Hi @keith @Wyverald and Bazel team,
I read the details of this issue and suggested fix. I like to work on this and provide a PR to fix the problem with 'archive_override' in 'MODULE.bazel'. I will start by checking the code at the provided link in BazelModuleResolutionFunction.java and come up with approach to introduce the necessary checks. Pls let me know if there r any additional considerations or if anyone else is already working on this.

[keith]

Sounds good!