Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULE.bazel.lock file is not updated when using bazel_features and setting os|arch_dependent #19662

Closed
aignas opened this issue Sep 28, 2023 · 5 comments
Assignees
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@aignas
Copy link

aignas commented Sep 28, 2023

Description of the bug:

I noticed the behavior that in rules_python examples/bzlmod executing:

git checkout f2a4dd5
USE_BAZEL_VERSION=last_green bazel test --lockfile_mode=update ...
# press Ctrl-C to abort requirements_test
git checkout main
USE_BAZEL_VERSION=last_green bazel test --lockfile_mode=update ...

yields to a different MODULE.bazel.lock file than just doing

bazel clean --async
USE_BAZEL_VERSION=last_green bazel test --lockfile_mode=update ...

See conversation:
bazelbuild/rules_python#1433 (comment)

cc: @fmeum

Which category does this issue belong to?

Core

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

See the description above.

Which operating system are you running Bazel on?

Linux

What is the output of bazel info release?

development version

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

USE_BAZEL_VERSION=last_green

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@fmeum
Copy link
Collaborator

fmeum commented Sep 28, 2023

I couldn't reproduce this with the given instructions, I got an empty diff. @Wyverald @SalmaSamy Could one of you try their luck?

There are two known issues with lockfile staleness for which fixes will be merged soon.

@iancha1992 iancha1992 added the team-Core Skyframe, bazel query, BEP, options parsing, bazelrc label Sep 28, 2023
@iancha1992 iancha1992 added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. area-Bzlmod Bzlmod-specific PRs, issues, and feature requests and removed team-Core Skyframe, bazel query, BEP, options parsing, bazelrc labels Sep 28, 2023
@Wyverald
Copy link
Member

I also can't reproduce; the two sets of commands yield exactly the same lockfile for me too. This is macOS 13.6 on an M1 Macbook.

@aignas
Copy link
Author

aignas commented Sep 29, 2023

It seems that I cannot reproduce it with the latest last_green either, but I can reproduce it with last_rc.

My repro script:

#!/bin/bash

export USE_BAZEL_VERSION=${USE_BAZEL_VERSION:-last_green}

git checkout f2a4dd5
bazel test --lockfile_mode=update ...
# press Ctrl-C to abort requirements_test
git checkout main
bazel test --lockfile_mode=update ...
mv MODULE.bazel.lock MODULE.bazel.lock.stale
bazel clean --async
bazel test --lockfile_mode=update ...
echo "Differences between the lock:"
diff MODULE.bazel.lock.stale MODULE.bazel.lock

echo "pip.parse extension should be platform dependent and the following text should have that metadata there:"
grep -A5 "%pip" MODULE.bazel.lock

last_green:

Note: switching to 'f2a4dd5'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at f2a4dd5 refactor(bzlmod)!: simplify pip.parse repository layout (#1395)
Starting local Bazel server and connecting to it...
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_9' from module 'other_module': Toolchain 'python_3_9' from module 'example_bzlmod' already registered Python version 3.9 and has precedence
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_11' from module 'other_module': Toolchain 'python_3_11' from module 'rules_python' already registered Python version 3.11 and has precedence
INFO: Analyzed 128 targets (161 packages loaded, 11866 targets configured).
INFO: Found 103 targets and 25 test targets...
INFO: Elapsed time: 65.647s, Critical Path: 19.50s
INFO: 334 processes: 191 internal, 139 linux-sandbox, 4 local.
INFO: Build completed successfully, 334 total actions
//:all_data_requirements                                                 PASSED in 0.0s
//:all_requirements                                                      PASSED in 0.0s
//:all_wheels                                                            PASSED in 0.0s
//:requirements_3_10_test                                                PASSED in 12.0s
//:requirements_3_9_test                                                 PASSED in 17.9s
//:test                                                                  PASSED in 0.8s
//:test_with_transition                                                  PASSED in 0.8s
//entry_points/tests:pylint_deps_test                                    PASSED in 2.6s
//entry_points/tests:pylint_test                                         PASSED in 2.8s
//entry_points/tests:yamllint_test                                       PASSED in 1.5s
//runfiles:runfiles_test                                                 PASSED in 0.7s
//tests:my_lib_3_10_test                                                 PASSED in 0.6s
//tests:my_lib_3_9_test                                                  PASSED in 0.4s
//tests:my_lib_default_test                                              PASSED in 0.3s
//tests:version_3_10_takes_3_9_subprocess_test                           PASSED in 0.5s
//tests:version_3_10_test                                                PASSED in 0.2s
//tests:version_3_11_test                                                PASSED in 0.2s
//tests:version_3_9_test                                                 PASSED in 0.2s
//tests:version_default_takes_3_10_subprocess_test                       PASSED in 0.4s
//tests:version_default_test                                             PASSED in 0.2s
//tests:version_test_binary_3_10                                         PASSED in 0.2s
//tests:version_test_binary_3_9                                          PASSED in 0.2s
//tests:version_test_binary_default                                      PASSED in 0.2s
//tests/other_module:other_module_bin_build_test                         PASSED in 0.1s
//whl_mods:pip_whl_mods_test                                             PASSED in 0.8s

Executed 25 out of 25 tests: 25 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
Previous HEAD position was f2a4dd5 refactor(bzlmod)!: simplify pip.parse repository layout (#1395)
Switched to branch 'main'
Your branch is ahead of 'origin/main' by 2 commits.
  (use "git push" to publish your local commits)
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_9' from module 'other_module': Toolchain 'python_3_9' from module 'example_bzlmod' already registered Python version 3.9 and has precedence
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_11' from module 'other_module': Toolchain 'python_3_11' from module 'rules_python' already registered Python version 3.11 and has precedence
Analyzing: 128 targets (140 packages loaded, 10958 targets configured)
    Fetching repository @rules_python~override~pip~pip_39_certifi; Restarting. 11s
    Fetching repository @rules_python~override~pip~pip_39_idna; starting 11s
    Fetching repository @rules_python~override~pip~pip_39_python_magic; starting 11s
    Fetching repository @rules_python~override~pip~pip_39_platformdirs; starting 11s
Analyzing: 128 targets (140 packages loaded, 10958 targets configured)
    Fetching repository @rules_python~override~pip~pip_39_certifi; Restarting. 12s
    Fetching repository @rules_python~override~pip~pip_39_idna; starting 12s
    Fetching repository @rules_python~override~pip~pip_39_python_magic; starting 12s
    Fetching repository @rules_python~override~pip~pip_39_platformdirs; starting 12s
Analyzing: 128 targets (140 packages loaded, 10958 targets configured)
    currently loading: @rules_python~override~pip~pip_39_python_magic//
    Fetching repository @rules_python~override~pip~pip_39_certifi; Restarting. 12s
    Fetching repository @rules_python~override~pip~pip_39_idna; starting 12s
    Fetching repository @rules_python~override~pip~pip_39_platformdirs; starting 12s
    Fetching repository @rules_python~override~
Analyzing: 128 targets (145 packages loaded, 11126 targets configured)
    Fetching repository @rules_python~override~pip~pip_39_certifi; Restarting. 13s
    Fetching repository @rules_python~override~pip~pip_39_platformdirs; starting 13s
    Fetching repository @rules_python~override~pip~pip_39_pylint_print; starting 13s
    Fetching repository @rules_python~override~pip~pip_39_chardet; Restarting. 13s
Analyzing: 128 targets (146 packages loaded, 11153 targets configured)
Analyzing: 128 targets (147 packages loaded, 11174 targets configured)
Analyzing: 128 targets (147 packages loaded, 11174 targets configured)
Analyzing: 128 targets (148 packages loaded, 11196 targets configured)
Analyzing: 128 targets (148 packages loaded, 11196 targets configured)
Analyzing: 128 targets (148 packages loaded, 11196 targets configured)
INFO: Analyzed 128 targets (162 packages loaded, 11907 targets configured).
INFO: Found 103 targets and 25 test targets...
[232 / 276] 5 actions, 4 running
    Creating runfiles tree bazel-out/k8-fastbuild-ST-d185d826a5f2/bin/requirements_3_10_test.ru
[257 / 288] 8 actions running
    Creating runfiles tree bazel-out/k8-fastbuild-ST-d185d826a5f2/bin/requirements_3_10_test.runfiles; 0s local
    RunBinary entry_points/tests/pylint_report.txt; 0s linux-sandbox
[286 / 294] 8 actions, 7 running
    Creating runfiles tree bazel-out/k8-fastbuild-ST-d185d826a5f2/bin/requirements_3_10_test.runfiles; 0s local
    RunBinary entry_points/tests/pylint_report.txt; 0s linux-sandbox
    Creating runfiles tree bazel-out/k8-fastbuild-ST-d185d826a5f2/bin/_requirements_3_10_test.runfiles; 0s local
    Creating runfiles tree bazel-out/k8-fastbuild-ST-d185d826a5f2/bin/requirements_3_10.update.
[287 / 296] 8 actions, 7 running
    Creating runfiles tree bazel-out/k8-fastbuild-ST-d185d826a5f2/bin/requirements_3_10_test.runfiles; 0s local
    RunBinary entry_points/tests/pylint_report.txt; 0s linux-sandbox
    Creating runfiles tree bazel-out/k8-fastbuild-ST-d185d826a5f2/bin/requirements_3_10.update.runfiles; 0s local
[305 / 314] 3 / 25 tests; 8 actions running; last test: //tests/other_module:other_module_bin_build_test
    RunBinary entry_points/tests/pylint_report.txt; 1s linux-sandbox
    Creating runfiles tree bazel-out/k8-fastbuild-ST-d185d826a5f2/bin/requirements_3_10.update.runfiles; 0s local
    Creating runfiles tree bazel-out/k8-fastbuild-ST-b5d3bee93ccd/bin/requirements_3_9.update.runfiles; 0s local
[325 / 332] 19 / 25 tests; 7 actions running; last test: //:all_wheels
    RunBinary entry_points/tests/pylint_report.txt; 1s linux-sandbox
INFO: Elapsed time: 43.366s, Critical Path: 18.81s
INFO: 109 processes: 72 internal, 33 linux-sandbox, 4 local.
INFO: Build completed successfully, 109 total actions
//:all_data_requirements                                        (cached) PASSED in 0.0s
//:all_requirements                                             (cached) PASSED in 0.0s
//:all_wheels                                                   (cached) PASSED in 0.0s
//entry_points/tests:yamllint_test                              (cached) PASSED in 1.5s
//runfiles:runfiles_test                                        (cached) PASSED in 0.7s
//tests:my_lib_3_10_test                                        (cached) PASSED in 0.6s
//tests:my_lib_3_9_test                                         (cached) PASSED in 0.4s
//tests:my_lib_default_test                                     (cached) PASSED in 0.3s
//tests:version_3_10_takes_3_9_subprocess_test                  (cached) PASSED in 0.5s
//tests:version_3_10_test                                       (cached) PASSED in 0.2s
//tests:version_3_11_test                                       (cached) PASSED in 0.2s
//tests:version_3_9_test                                        (cached) PASSED in 0.2s
//tests:version_default_takes_3_10_subprocess_test              (cached) PASSED in 0.4s
//tests:version_default_test                                    (cached) PASSED in 0.2s
//tests:version_test_binary_3_10                                (cached) PASSED in 0.2s
//tests:version_test_binary_3_9                                 (cached) PASSED in 0.2s
//tests:version_test_binary_default                             (cached) PASSED in 0.2s
//tests/other_module:other_module_bin_build_test                (cached) PASSED in 0.1s
//whl_mods:pip_whl_mods_test                                    (cached) PASSED in 0.8s
//:requirements_3_10_test                                                PASSED in 11.9s
//:requirements_3_9_test                                                 PASSED in 17.9s
//:test                                                                  PASSED in 0.6s
//:test_with_transition                                                  PASSED in 0.7s
//entry_points/tests:pylint_deps_test                                    PASSED in 1.9s
//entry_points/tests:pylint_test                                         PASSED in 2.5s

Executed 6 out of 25 tests: 25 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Starting clean.
INFO: Output tree moved to /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/execroot_tmp_84330_fa7d5f4a-4c3c-47b1-81ae-3089c9a4b5f8 for deletion
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_9' from module 'other_module': Toolchain 'python_3_9' from module 'example_bzlmod' already registered Python version 3.9 and has precedence
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_11' from module 'other_module': Toolchain 'python_3_11' from module 'rules_python' already registered Python version 3.11 and has precedence
INFO: Analyzed 128 targets (162 packages loaded, 11907 targets configured).
INFO: Found 103 targets and 25 test targets...
INFO: Elapsed time: 38.952s, Critical Path: 28.44s
INFO: 334 processes: 191 internal, 139 linux-sandbox, 4 local.
INFO: Build completed successfully, 334 total actions
//:all_data_requirements                                                 PASSED in 0.1s
//:all_requirements                                                      PASSED in 0.1s
//:all_wheels                                                            PASSED in 0.1s
//:requirements_3_10_test                                                PASSED in 12.1s
//:requirements_3_9_test                                                 PASSED in 19.5s
//:test                                                                  PASSED in 0.9s
//:test_with_transition                                                  PASSED in 0.8s
//entry_points/tests:pylint_deps_test                                    PASSED in 2.3s
//entry_points/tests:pylint_test                                         PASSED in 2.5s
//entry_points/tests:yamllint_test                                       PASSED in 1.3s
//runfiles:runfiles_test                                                 PASSED in 0.7s
//tests:my_lib_3_10_test                                                 PASSED in 0.6s
//tests:my_lib_3_9_test                                                  PASSED in 0.3s
//tests:my_lib_default_test                                              PASSED in 0.4s
//tests:version_3_10_takes_3_9_subprocess_test                           PASSED in 0.6s
//tests:version_3_10_test                                                PASSED in 0.2s
//tests:version_3_11_test                                                PASSED in 0.2s
//tests:version_3_9_test                                                 PASSED in 0.2s
//tests:version_default_takes_3_10_subprocess_test                       PASSED in 0.6s
//tests:version_default_test                                             PASSED in 0.2s
//tests:version_test_binary_3_10                                         PASSED in 0.2s
//tests:version_test_binary_3_9                                          PASSED in 0.2s
//tests:version_test_binary_default                                      PASSED in 0.2s
//tests/other_module:other_module_bin_build_test                         PASSED in 0.1s
//whl_mods:pip_whl_mods_test                                             PASSED in 0.8s

Executed 25 out of 25 tests: 25 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
Differences between the lock:
pip.parse extension should be platform dependent and the following text should have that metadata there:
    "@rules_python~override//python/extensions:pip.bzl%pip": {
      "os:linux,arch:amd64": {
        "bzlTransitiveDigest": "l3WNJ4zLQn3ku8nXb4LH/ldlBkNsPVTs4l9deKD1q/4=",
        "accumulatedFileDigests": {
          "@@//:requirements_lock_3_10.txt": "8a691c254cde6884cef3fd9f75479cc10118b6886f6ba44721501f37e1266c1c",
          "@@//whl_mods:appended_build_content.BUILD": "275102ec5574229531650038302ac51025d72e7f7a5c65c01cf33a96d1e646dd",

last_rc:

$ USE_BAZEL_VERSION=last_rc ~/tmp/repro.sh
Note: switching to 'f2a4dd5'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at f2a4dd5 refactor(bzlmod)!: simplify pip.parse repository layout (#1395)
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_9' from module 'other_module': Toolchain 'python_3_9' from module 'example_bzlmod' already registered Python version 3.9 and has precedence
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_11' from module 'other_module': Toolchain 'python_3_11' from module 'rules_python' already registered Python version 3.11 and has precedence
INFO: Analyzed 128 targets (151 packages loaded, 12416 targets configured).
INFO: Found 103 targets and 25 test targets...
INFO: Elapsed time: 51.437s, Critical Path: 16.61s
INFO: 334 processes: 191 internal, 139 linux-sandbox, 4 local.
INFO: Build completed successfully, 334 total actions
//:all_data_requirements                                                 PASSED in 0.0s
//:all_requirements                                                      PASSED in 0.0s
//:all_wheels                                                            PASSED in 0.0s
//:requirements_3_10_test                                                PASSED in 9.8s
//:requirements_3_9_test                                                 PASSED in 15.5s
//:test                                                                  PASSED in 0.7s
//:test_with_transition                                                  PASSED in 1.0s
//entry_points/tests:pylint_deps_test                                    PASSED in 2.0s
//entry_points/tests:pylint_test                                         PASSED in 3.5s
//entry_points/tests:yamllint_test                                       PASSED in 1.7s
//runfiles:runfiles_test                                                 PASSED in 0.8s
//tests:my_lib_3_10_test                                                 PASSED in 0.5s
//tests:my_lib_3_9_test                                                  PASSED in 0.4s
//tests:my_lib_default_test                                              PASSED in 0.6s
//tests:version_3_10_takes_3_9_subprocess_test                           PASSED in 0.8s
//tests:version_3_10_test                                                PASSED in 0.2s
//tests:version_3_11_test                                                PASSED in 0.2s
//tests:version_3_9_test                                                 PASSED in 0.2s
//tests:version_default_takes_3_10_subprocess_test                       PASSED in 0.4s
//tests:version_default_test                                             PASSED in 0.3s
//tests:version_test_binary_3_10                                         PASSED in 0.2s
//tests:version_test_binary_3_9                                          PASSED in 0.2s
//tests:version_test_binary_default                                      PASSED in 0.2s
//tests/other_module:other_module_bin_build_test                         PASSED in 0.1s
//whl_mods:pip_whl_mods_test                                             PASSED in 0.7s

Executed 25 out of 25 tests: 25 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
Previous HEAD position was f2a4dd5 refactor(bzlmod)!: simplify pip.parse repository layout (#1395)
Switched to branch 'main'
Your branch is ahead of 'origin/main' by 2 commits.
  (use "git push" to publish your local commits)
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_9' from module 'other_module': Toolchain 'python_3_9' from module 'example_bzlmod' already registered Python version 3.9 and has precedence
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_11' from module 'other_module': Toolchain 'python_3_11' from module 'rules_python' already registered Python version 3.11 and has precedence
INFO: Analyzed 128 targets (152 packages loaded, 12457 targets configured).
INFO: Found 103 targets and 25 test targets...
INFO: Elapsed time: 41.844s, Critical Path: 18.49s
INFO: 64 processes: 27 internal, 33 linux-sandbox, 4 local.
INFO: Build completed successfully, 64 total actions
//:all_data_requirements                                        (cached) PASSED in 0.0s
//:all_requirements                                             (cached) PASSED in 0.0s
//:all_wheels                                                   (cached) PASSED in 0.0s
//entry_points/tests:yamllint_test                              (cached) PASSED in 1.7s
//runfiles:runfiles_test                                        (cached) PASSED in 0.8s
//tests:my_lib_3_10_test                                        (cached) PASSED in 0.5s
//tests:my_lib_3_9_test                                         (cached) PASSED in 0.4s
//tests:my_lib_default_test                                     (cached) PASSED in 0.6s
//tests:version_3_10_takes_3_9_subprocess_test                  (cached) PASSED in 0.8s
//tests:version_3_10_test                                       (cached) PASSED in 0.2s
//tests:version_3_11_test                                       (cached) PASSED in 0.2s
//tests:version_3_9_test                                        (cached) PASSED in 0.2s
//tests:version_default_takes_3_10_subprocess_test              (cached) PASSED in 0.4s
//tests:version_default_test                                    (cached) PASSED in 0.3s
//tests:version_test_binary_3_10                                (cached) PASSED in 0.2s
//tests:version_test_binary_3_9                                 (cached) PASSED in 0.2s
//tests:version_test_binary_default                             (cached) PASSED in 0.2s
//tests/other_module:other_module_bin_build_test                (cached) PASSED in 0.1s
//whl_mods:pip_whl_mods_test                                    (cached) PASSED in 0.7s
//:requirements_3_10_test                                                PASSED in 11.8s
//:requirements_3_9_test                                                 PASSED in 17.2s
//:test                                                                  PASSED in 0.7s
//:test_with_transition                                                  PASSED in 0.7s
//entry_points/tests:pylint_deps_test                                    PASSED in 1.8s
//entry_points/tests:pylint_test                                         PASSED in 2.2s

Executed 6 out of 25 tests: 25 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Starting clean.
INFO: Output tree moved to /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/execroot_tmp_90381_cd5e0445-f211-4913-8a98-3905d2651d4f for deletion
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_9' from module 'other_module': Toolchain 'python_3_9' from module 'example_bzlmod' already registered Python version 3.9 and has precedence
DEBUG: /home/aignas/.cache/bazel/_bazel_aignas/3a6ae8a9f0b6d56262b422499f6b0475/external/rules_python~override/python/extensions/python.bzl:44:10: WARNING: Ignoring toolchain 'python_3_11' from module 'other_module': Toolchain 'python_3_11' from module 'rules_python' already registered Python version 3.11 and has precedence
INFO: Analyzed 128 targets (152 packages loaded, 12457 targets configured).
INFO: Found 103 targets and 25 test targets...
INFO: Elapsed time: 37.787s, Critical Path: 20.44s
INFO: 334 processes: 191 internal, 139 linux-sandbox, 4 local.
INFO: Build completed successfully, 334 total actions
//:all_data_requirements                                                 PASSED in 0.0s
//:all_requirements                                                      PASSED in 0.0s
//:all_wheels                                                            PASSED in 0.0s
//:requirements_3_10_test                                                PASSED in 13.1s
//:requirements_3_9_test                                                 PASSED in 19.1s
//:test                                                                  PASSED in 0.7s
//:test_with_transition                                                  PASSED in 0.5s
//entry_points/tests:pylint_deps_test                                    PASSED in 2.8s
//entry_points/tests:pylint_test                                         PASSED in 2.9s
//entry_points/tests:yamllint_test                                       PASSED in 1.5s
//runfiles:runfiles_test                                                 PASSED in 0.7s
//tests:my_lib_3_10_test                                                 PASSED in 0.4s
//tests:my_lib_3_9_test                                                  PASSED in 0.3s
//tests:my_lib_default_test                                              PASSED in 0.3s
//tests:version_3_10_takes_3_9_subprocess_test                           PASSED in 0.4s
//tests:version_3_10_test                                                PASSED in 0.2s
//tests:version_3_11_test                                                PASSED in 0.2s
//tests:version_3_9_test                                                 PASSED in 0.2s
//tests:version_default_takes_3_10_subprocess_test                       PASSED in 0.4s
//tests:version_default_test                                             PASSED in 0.2s
//tests:version_test_binary_3_10                                         PASSED in 0.2s
//tests:version_test_binary_3_9                                          PASSED in 0.2s
//tests:version_test_binary_default                                      PASSED in 0.2s
//tests/other_module:other_module_bin_build_test                         PASSED in 0.2s
//whl_mods:pip_whl_mods_test                                             PASSED in 0.7s

Executed 25 out of 25 tests: 25 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
Differences between the lock:
pip.parse extension should be platform dependent and the following text should have that metadata there:
    "@rules_python~override//python/extensions:pip.bzl%pip": {
      "general": {
        "bzlTransitiveDigest": "R2qMlVD81xg0E6ZTfPsWswckEk8WiWSPG/5CCuzkKE0=",
        "accumulatedFileDigests": {
          "@@//:requirements_lock_3_10.txt": "8a691c254cde6884cef3fd9f75479cc10118b6886f6ba44721501f37e1266c1c",
          "@@//whl_mods:appended_build_content.BUILD": "275102ec5574229531650038302ac51025d72e7f7a5c65c01cf33a96d1e646dd",

Note, that with last_rc the extension does not use the os/arch specific feature, which is not what I would expect, but with last_green everything is OK, so this ticket may be a duplicate of a known issue.

@meteorcloudy meteorcloudy added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Oct 10, 2023
@fmeum
Copy link
Collaborator

fmeum commented Nov 20, 2023

The repro doesn't include bazel clean --expunge, which makes me think this is caused by bazel-contrib/bazel_features#25. @aignas Could you retest with the latest bazel_features version and/or the --expunge option?

@fmeum
Copy link
Collaborator

fmeum commented Nov 30, 2023

I assume that this is fixed, @aignas please let us know if that shouldn't be the case.

@fmeum fmeum closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Development

No branches or pull requests

8 participants