Implement TEST_PREMATURE_EXIT_FILE
#23284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bazel test docs claim that a test will fail if a file exists at the path indicated by `TEST_PREMATURE_EXIT_FILE`, but this has not yet been the case in Bazel. This feature is used by `googletest` (https://google.github.io/googletest/advanced.html#detecting-test-premature-exit).
github-actions
bot
added
team-Remote-Exec
|
@lberki Is this feature supported by the internal test strategy implementation? Could you also let me know what |
tjgq
added
team-Core
|
@lberki Friendly ping |
lberki
reviewed
Sep 16, 2024
lberki
approved these changes
Sep 16, 2024
lberki
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bazel test docs claim that a test will fail if a file exists at the path indicated by
TEST_PREMATURE_EXIT_FILE, but this has not yet been the case in Bazel.This feature is used by
googletest(https://google.github.io/googletest/advanced.html#detecting-test-premature-exit).