Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.5.0 documentation is starting to wither away #23480

Closed
grepwood opened this issue Aug 30, 2024 · 4 comments
Closed

6.5.0 documentation is starting to wither away #23480

grepwood opened this issue Aug 30, 2024 · 4 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: documentation (cleanup)

Comments

@grepwood
Copy link

Page link:

https://bazel.build/versions/6.5.0/rules/lib/builtins/repository_ctx

Problem description (include actual vs expected text, if applicable):

It should not be 404. There are still people who have barely migrated from 5.x.x.

Where do you see this issue? (include link to specific section of the page, if applicable)

On the specified link

Any other information you'd like to share?

Please stop pre-emptively burning the documentation for older releases.

@grepwood grepwood added team-Documentation Documentation improvements that cannot be directly linked to other team labels type: documentation (cleanup) untriaged labels Aug 30, 2024
@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Aug 30, 2024
@Wyverald
Copy link
Member

cc @fweikert

The old page is actually still there (https://bazel.build/versions/6.5.0/rules/lib/repository_ctx -- note the missing builtins segment between lib and repository_ctx); the new version selector makes it go to the "imaginary" new URL.

I wonder if this is as simple as fixing the set_var clause in the 6.5.0 pages? Also need to figure out why the navbar on the left is empty.

@meteorcloudy
Copy link
Member

Yeah, for older docs, please start navigating from https://bazel.build/versions/6.5.0

@meteorcloudy meteorcloudy added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Sep 10, 2024
@fweikert
Copy link
Member

There are two problems:

  1. Because of 6dbac49 the generated Starlark docs prior to 7.x have a different layout. The only solution is adding redirects.

  2. Between 6.2 and 6.3 the left navbar disappeared: https://bazel.build/versions/6.2.0/reference/be/overview vs https://bazel.build/versions/6.3.0/reference/be/overview

@fweikert
Copy link
Member

Both of the aforementioned issues have been fixed.

There is still a problem, though: Whenever we introduce new Starlark symbols, the version selector will lead to 404 errors when switching to versions that don't contain these symbols yet. I guess we need to set up another bunch of redirects when 8.0 comes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: documentation (cleanup)
Projects
None yet
Development

No branches or pull requests

7 participants