Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules_java 7.11.1 / java_tools 13.8 #23571

Closed
wants to merge 2 commits into from
Closed

Conversation

hvadehra
Copy link
Member

No description provided.

@hvadehra hvadehra force-pushed the hvd_p23515 branch 3 times, most recently from 9dc0b99 to e44b461 Compare September 10, 2024 09:28
@iancha1992
Copy link
Member

@hvadehra do you want this in 7.4.0?

@hvadehra
Copy link
Member Author

do you want this in 7.4.0?

@comius @fmeum WDYT?

@fmeum
Copy link
Collaborator

fmeum commented Sep 12, 2024

do you want this in 7.4.0?

@comius @fmeum WDYT?

I don't see any downside and as far as I remember this also contains a Turbine fix, so yes.

@iancha1992
Copy link
Member

@bazel-io fork 7.4.0

@iancha1992
Copy link
Member

iancha1992 commented Sep 12, 2024

@hvadehra @fmeum
Also, just want to let you know that the few downstream is failing here, but they seem to be going through in the master. Might want to take a look at these:

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4118#0191e379-143f-4466-b517-670955e71972
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4118#0191e37d-98da-4077-8196-c541a596a3dc
All of rules_kotlin are failing here as well

Are these safe to ignore?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants