Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration needed for Automatic Exec Groups #24373

Open
kotlaja opened this issue Nov 18, 2024 · 1 comment
Open

Migration needed for Automatic Exec Groups #24373

kotlaja opened this issue Nov 18, 2024 · 1 comment
Labels
breakage incompatible-change Incompatible/breaking change team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request

Comments

@kotlaja
Copy link
Contributor

kotlaja commented Nov 18, 2024

Migration to Automatic Exec Groups (AEGs) is needed since its incompatible flag (--incompatible_auto_exec_groups) will be enabled for Bazel@Head by default shortly, thus it will be breaking multiple projects.

Please migrate and fix potential errors, in order to unblock your project and users who depend on your project. Potential errors can be triggered by building your project with this incompatible flag. Note that AEGs will not be flipped by default for Bazel 8, but for Bazel at head after Bazel 8 cut.

For more details, please check:

Notes

  • Issues related to this matter were already open for multiple modules, but github suspended the account of the colleague who opened them (the issue was probably related to using a similar template for multiple projects which was observed as spam). Hence, I’m opening this single issue and I’m pinging maintainers of relevant failing projects which require this migration.
  • In case the migration is not straightforward, please open an additional github issue in your repository in order to closely follow the progress. In this way we’re being respectful towards other maintainers of different projects, who share this issue along with us.
  • In case there are some obstacles, please let me know.
  • Let me know if I made some mistake or some changes need to be done regarding maintainers - Most of the information I used from Bazel Central Registry.

The following modules are broken with Bazel 7:

BCR Bazel Compatibility Test: https://buildkite.com/bazel/bcr-bazel-compatibility-test/builds/45

aspect_rules_js

Maintainers: @alexeagle, @gregmagolan, @jbedard

aspect_rules_lint:

Maintainers: @alexeagle

rules_nodejs

Maintainers: @alexeagle

toolchains_protoc

Maintainers: @alexeagle

apple_support@1.17.1

Maintainers: @keith, @BalestraPatrick

rules_swift

Maintainers: @keith, @BalestraPatrick, @brentleyjones

rules_apple

Maintainers: @keith, @BalestraPatrick, @brentleyjones

swift_argument_parser

Maintainers: @keith, @jpsim

bazel_skylib_gazelle_plugin

Maintainers: @comius

cgrindel_bazel_starlib

Maintainers: @cgrindel

gazelle

Maintainers: @fmeum, @linzhp, @tyler-french

rules_go

Maintainers: @fmeum, @linzhp, @tyler-french

grpc

Maintainers: @apolcyn, @arjunroy, @ctiller

protobuf

Maintainers: @haberman, @deannagarcia

rules_android

Maintainers: @ted-xie, @ahumesky

rules_buf

Maintainers: @srikrsna-buf

rules_coreutils

Maintainers: @mattyclarkson

rules_diff

Maintainers: @mattyclarkson

rules_foreign_cc

Maintainers: @jsharpe

rules_python

Maintainers: @rickeylev, @aignas

rules_python_gazelle_plugin

Maintainers: @rickeylev, @aignas

libpfm

Maintainers: TBD

libzmq

Maintainers: TBD

rules_erlang

Maintainers: TBD

@rickeylev
Copy link
Contributor

rules_python:

	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f0406cbf12177f6cbe046ff7eea9e4d2/external/protobuf~/python/internal.bzl", line 57, column 24, in _internal_copy_files_impl
		ctx.actions.run(
Error in run: Couldn't identify if tools are from implicit dependencies or a toolchain. Please set the toolchain parameter. If you're not using a toolchain, set it to 'None'.

rules_python is using the latest protobuf release. I've filed protocolbuffers/protobuf#19313

@sgowroji sgowroji added type: feature request breakage team-Configurability platforms, toolchains, cquery, select(), config transitions incompatible-change Incompatible/breaking change labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakage incompatible-change Incompatible/breaking change team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants