Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility doesn't work across bound labels #388

Closed
lberki opened this issue Aug 24, 2015 · 2 comments
Closed

Visibility doesn't work across bound labels #388

lberki opened this issue Aug 24, 2015 · 2 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional)

Comments

@lberki
Copy link
Contributor

lberki commented Aug 24, 2015

Example:

WORKSPACE:

local_repository(
    name = "r",
    path = "$r",
)

bind(
    name = "e",
    actual = "@r//:g",
)

BUILD:

genrule(
    name = "r",
    srcs = ["//external:e"],
    outs = ["r.out"],
    cmd = "cp \$< \$@",
)

genrule(
    name = "g",
    srcs = [],
    outs = ["g.out"],
    cmd = "echo GOLF > \$@",
)
EOF

Reports a visibility error, even though the two targets are in the same package. Furthermore, the visibility error doesn't say that it's a :r -> :g edge, but that it's a //external:e -> :g one.

@lberki lberki added the P2 We'll consider working on this in future. (Assignee optional) label Aug 24, 2015
@lberki
Copy link
Contributor Author

lberki commented Aug 24, 2015

@kchodorow : assigning this you since it's remote repository related.

@lberki lberki assigned lberki and unassigned kchodorow Aug 24, 2015
@lberki
Copy link
Contributor Author

lberki commented Aug 24, 2015

Thinking again, I'll just fix this. It's a trivial fix, so let's not make you switch context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional)
Projects
None yet
Development

No branches or pull requests

2 participants