Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring bazel itself? #521

Closed
pspeter3 opened this issue Oct 21, 2015 · 8 comments
Closed

Vendoring bazel itself? #521

pspeter3 opened this issue Oct 21, 2015 · 8 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: documentation (cleanup)

Comments

@pspeter3
Copy link

Does it makes sense to vendor the bazel tool for consistent builds? If so, what is the best way to vendor it.

@hanwen
Copy link
Contributor

hanwen commented Oct 21, 2015

The Bazel tool is a single binary; You can check it into your repo, and then run it from the repo.

@pspeter3
Copy link
Author

@hanwen Sounds good though I would need to check in a version per environment theoretically?

@hanwen
Copy link
Contributor

hanwen commented Oct 21, 2015

I guess so. You could have a wrapper scrpit that selects linux/osx based on uname.

@pspeter3
Copy link
Author

I guess what I'm asking more is it possible for a workspace to specify a Bazel version or version range? Sorry for the confusion around the original question

@davidzchen
Copy link
Member

Would it be a good idea to add a tutorial or some documentation on how to vendor Bazel? IIRC, there has been a couple of other email threads in the past on the mailing list asking about this as well.

@bsilver8192
Copy link
Contributor

I think the idea proposed by #373 (create a wrapper script which downloads a fixed version from a fixed URL) is a good idea.

@AustinSchuh
Copy link
Contributor

Is there a way to have the locally installed version of bazel (or maybe a wrapper shell script which is locally installed which runs the real bazel as a backup) look for this wrapper script? That would make it so you can choose to vendor, but it isn't the only way to do it, and you can make the choice to vendor per repo and don't have to re-train users to use the checked in shell script.

@damienmg damienmg added under investigation type: documentation (cleanup) P3 We're not considering working on this, but happy to review a PR. (No assignee) release / binary and removed question under investigation labels Nov 17, 2015
@bsilver8192
Copy link
Contributor

I wrote up something like what @AustinSchuh described and sent it for review as https://bazel-review.googlesource.com/2620. Comments/suggestions/etc welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: documentation (cleanup)
Projects
None yet
Development

No branches or pull requests

6 participants