Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_remove_host_cc_options: Remove host exclusive C++ options #7406

Closed
hlopko opened this issue Feb 12, 2019 · 2 comments
Closed

incompatible_remove_host_cc_options: Remove host exclusive C++ options #7406

hlopko opened this issue Feb 12, 2019 · 2 comments
Assignees
Labels
incompatible-change Incompatible/breaking change P1 I'll work on this now. (Assignee required) team-Rules-CPP Issues for C++ rules

Comments

@hlopko
Copy link
Member

hlopko commented Feb 12, 2019

Flag: --incompatible_remove_host_specific_cc_options
Available since: todo
Will be flipped in: todo
Tracking issue: #6516

Motivation

With the move of C++ rules to use platforms/toolchains (tracked in #6516), we are removing host specific logic. Platforms don't guarantee existence of separate host toolchain, in which case having both --host_copt and --copt is confusing, and it can happen that there will be multiple execution platforms, which currently don't have a --copt flag. My research shows that these Bazel options are actually mostly unused, so instead of coming up with non-trivial solution, we will remove these options.

There are already mechanisms how to alter the command lines - crosstool features, and/or copts and linkopts attributes on rules. If this is not enough, we can investigate other options. Feel free to start the conversation on this issue.

Migration

Affected options:

  • --host_copt
  • --host_cxxopt
  • --host_conlyopt
  • --host_linkopt
  • --host_grte_top

These will be removed. Migration options are using rule attributes, and crosstool features.

@hlopko hlopko added P1 I'll work on this now. (Assignee required) team-Rules-CPP Issues for C++ rules incompatible-change Incompatible/breaking change bazel 1.0 labels Feb 12, 2019
@hlopko hlopko self-assigned this Feb 12, 2019
@hlopko hlopko changed the title incompatible_remove_host_copts_linkopts: Remove host exclusive copts and linkopts options incompatible_remove_host_cc_options: Remove host exclusive C++ options Feb 12, 2019
@hlopko
Copy link
Member Author

hlopko commented Feb 12, 2019

CC @katre

@hlopko
Copy link
Member Author

hlopko commented Mar 25, 2019

Closing - this is no longer needed for C++ rules to migrate to platforms.

@hlopko hlopko closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible-change Incompatible/breaking change P1 I'll work on this now. (Assignee required) team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

No branches or pull requests

1 participant