Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Authentication in jvm_maven_import_external/java_import_external #7443

Closed
guw opened this issue Feb 15, 2019 · 3 comments
Closed

Support Authentication in jvm_maven_import_external/java_import_external #7443

guw opened this issue Feb 15, 2019 · 3 comments
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request untriaged

Comments

@guw
Copy link
Contributor

guw commented Feb 15, 2019

Description of the problem:

With #6799 native.maven_rule is going away. It supported reading authentication credentials for a Maven repository from ~/.m2/settings.xml. jvm_maven_import_external (which is recommended as a replacement in #6799) does not support authentication.

Feature requests: what underlying problem are you trying to solve with this feature?

In certain networks access to public Maven Central is not possible. Instead people have to go through an internal Maven repository. This requires authentication. It must be possible to download jars from Maven repositories that require authentication.

Note, some Maven repositories do not support URL style submitting of username and password. Thus, it must be provided by a HTTP header.

Notes:

Support for Basic Authentication should be sufficient in the first place.

Reading username/password from ~/.m2/settings.xml would be ideal (convenient but not mandatory as long as it's decoupled from Bazel BUILD/WORKSPACE files).

@cgruber
Copy link
Contributor

cgruber commented Feb 23, 2019

I'm not sure if this is simply a problem with the rule... I don't see any particular mechanism to instruct repository_ctx.download() to use some authentication. I'm having a similar issue with bintray returning html login pages, instead of .pom files in Square's maven integration. :/

@guw
Copy link
Contributor Author

guw commented Feb 24, 2019

@cgruber See #7469.

@meisterT
Copy link
Member

Is there anything left to do here?

@meisterT meisterT added untriaged and removed P1 I'll work on this now. (Assignee required) labels May 12, 2020
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@philwo philwo closed this as completed Feb 8, 2021
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request untriaged
Projects
None yet
Development

No branches or pull requests

7 participants