Separate ijar sources from deployment zip. #12556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@comius Can you check out the test failures? |
Done, I love monorepos. |
bazel-io
pushed a commit
that referenced
this pull request
Nov 25, 2020
This is a github only patch from PR #12546. Needs to go in first. PiperOrigin-RevId: 344260438
bazel-io
pushed a commit
that referenced
this pull request
Nov 27, 2020
…lt part. This builds on top of the commit "Separate java_tools into platform independent and prebuilt part.". - java_tools release 11.0 is used - java_tools platform independent repo is added - java toolchain definitions appropriate for new release are added to tools/jdk/BUILD - remote_java_tools are replaced with aliases - tests are reenabled Changelog: ``` $ git log --pretty=format:"%h %an %s" cd3480e...5a91c25 -- src/java_tools/ third_party/ijar/ tools/jdk/BUILD.java_tools d10013d Ivo List Separate java_tools into platform independent and prebuilt part. 3c9ad2d philwo Separate ijar sources from deployment zip. (#12556) 2d990cf philwo Fix #10127: Remove Python 2 dependency from tools/android. de2dab0 Ivo List Separate ijar sources from deployment zip. b17e9e4 Googler Automatic code cleanup. ``` Benchmark: ``` Bazel commit: /tmp/bazel-head, Project commit: c85ecbe, Project source: None metric mean median stddev pval wall: 185.647s 185.445s 2.224s cpu: 55.616s 54.410s 1.792s system: 18.043s 18.060s 0.330s memory: 94.000s 94.000s 0.000s Bazel commit: /tmp/comius-bazel, Project commit: c85ecbe, Project source: None metric mean median stddev pval wall: 184.544s ( -0.59%) 184.456s ( -0.53%) 1.626s 0.03730 cpu: 54.484s ( -2.03%) 54.990s ( +1.07%) 1.940s 0.42483 system: 17.364s ( -3.76%) 17.260s ( -4.43%) 0.392s 0.94697 memory: 94.000s ( +0.00%) 94.000s ( +0.00%) 0.000s 0.00000 ``` Closes #12552. Fixes #8406. PiperOrigin-RevId: 344530341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a github only patch from PR #12546. Needs to go in first.