Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix https://github.com/bazelbuild/bazel/issues/18493. #18498

Closed
wants to merge 1 commit into from
Closed

Fix https://github.com/bazelbuild/bazel/issues/18493. #18498

wants to merge 1 commit into from

Conversation

meisterT
Copy link
Member

@meisterT meisterT commented May 25, 2023 •
edited by meteorcloudy
Loading

The use of the pipe in
b8e92cc made it swallow the exit code, so we need to set pipefail.

Fix #18493

@meisterT
Fix bazelbuild#18493.
d3bb7bc 
The use of the pipe in
bazelbuild@b8e92cc
made it swallow the exit code, so we need to set pipefail.
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 25, 2023
@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label May 25, 2023
@meteorcloudy
Copy link
Member

/cc @keertk @iancha1992

@keertk
Copy link
Member

keertk commented May 25, 2023

@meteorcloudy / @meisterT is this PR ready to be imported?

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 25, 2023
@meteorcloudy
Copy link
Member

@keertk Yes, sorry for forgetting to apply the label.

@Pavank1992 Pavank1992 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 26, 2023
@Pavank1992 Pavank1992 mentioned this pull request May 26, 2023
Closed
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 26, 2023
@brentleyjones
Copy link
Contributor

#18509

@meteorcloudy
Copy link
Member

The issue this PR trying to fix is already marked for cherry picking for 6.2.1 and 6.3.0

@meteorcloudy meteorcloudy removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 26, 2023
@keertk keertk mentioned this pull request May 26, 2023
Merged
meteorcloudy pushed a commit that referenced this pull request May 26, 2023
@keertk @meisterT
Fix #18493. (#18512)
35bad7e 
The use of the pipe in
b8e92cc made it swallow the exit code, so we need to set pipefail.

Fix #18493

Closes #18498.

PiperOrigin-RevId: 535520323
Change-Id: Idf1a5c39bf5b7deec29b76c10ece2825b568ebf2

Co-authored-by: Tobias Werth <twerth@google.com>
@Pavank1992 Pavank1992 mentioned this pull request May 26, 2023
Merged
meteorcloudy pushed a commit that referenced this pull request May 30, 2023
@Pavank1992 @meisterT
Fix #18493. (#18514)
a93c460 
The use of the pipe in
b8e92cc made it swallow the exit code, so we need to set pipefail.

Fix #18493

Closes #18498.

PiperOrigin-RevId: 535520323
Change-Id: Idf1a5c39bf5b7deec29b76c10ece2825b568ebf2

Co-authored-by: Tobias Werth <twerth@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bazel run test_target doesn't convey test exit code
7 participants
@meisterT @meteorcloudy @keertk @brentleyjones @bazel-io @sgowroji @Pavank1992