Profiler: fix wrong field name #23046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in bazelbuild#22505, I misread the initial implemenation and named this field wrongly. Given there has been no report about this before this issue, it's safe to assume that the field is not widely used by other folks and therefore, is safe to change. Closes bazelbuild#22505.
github-actions
bot
added
team-Performance
|
cc @meisterT |
meisterT
approved these changes
Jul 22, 2024
meisterT
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #22505, I misread the initial implemenation and named
this field wrongly. Given there has been no report about this before
this issue, it's safe to assume that the field is not widely used by
other folks and therefore, is safe to change.
Closes #22505.