Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip use output paths #23582

Closed

Conversation

sluongng
Copy link
Contributor

Base on #18270

Flip the flag in preparation for the next major release.

@sluongng sluongng requested a review from a team as a code owner September 10, 2024 15:42
@github-actions github-actions bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Sep 10, 2024
@sgowroji sgowroji added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 11, 2024
@sluongng sluongng force-pushed the sluongng/flip-use-output-paths branch from a76e3e0 to 5093d92 Compare September 11, 2024 10:46
sluongng added a commit to sluongng/bazel that referenced this pull request Sep 11, 2024
@sluongng sluongng force-pushed the sluongng/flip-use-output-paths branch from 5093d92 to 073aecd Compare September 11, 2024 12:52
sluongng added a commit to sluongng/bazel that referenced this pull request Sep 11, 2024
@sluongng sluongng force-pushed the sluongng/flip-use-output-paths branch from 073aecd to 4602931 Compare September 11, 2024 13:19
sluongng added a commit to sluongng/bazel that referenced this pull request Sep 11, 2024
@sluongng sluongng force-pushed the sluongng/flip-use-output-paths branch from 4602931 to 0a10cdb Compare September 11, 2024 13:41
sluongng added a commit to sluongng/bazel that referenced this pull request Sep 11, 2024
sluongng added a commit to sluongng/bazel that referenced this pull request Sep 12, 2024
@sluongng sluongng force-pushed the sluongng/flip-use-output-paths branch from 0a10cdb to 657e34c Compare September 12, 2024 12:56
sluongng added a commit to sluongng/bazel that referenced this pull request Sep 12, 2024
@sluongng sluongng force-pushed the sluongng/flip-use-output-paths branch from 657e34c to 8ce2c82 Compare September 12, 2024 14:09
sluongng added a commit to sluongng/bazel that referenced this pull request Sep 12, 2024
@coeuvre
Copy link
Member

coeuvre commented Sep 16, 2024

Thanks! But we decided to not add the flag in 164705b.

@coeuvre coeuvre closed this Sep 16, 2024
sluongng added a commit to sluongng/bazel that referenced this pull request Sep 16, 2024
sluongng added a commit to sluongng/bazel that referenced this pull request Sep 16, 2024
copybara-service bot pushed a commit that referenced this pull request Sep 17, 2024
Follow up of #23582 and #18270

Closes #23593.

PiperOrigin-RevId: 675474682
Change-Id: I83df904f6dbd6e0f8fb87e09bd6dc2428c94bee6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-response Awaiting a response from the author team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants