Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow synchronization via bazel query #4792

Closed
DeCarabas opened this issue Apr 25, 2023 · 4 comments
Closed

Allow synchronization via bazel query #4792

DeCarabas opened this issue Apr 25, 2023 · 4 comments
Labels
os: linux Linux support P3 We're not considering working on this, but happy to review a PR. (No assignee) product: IntelliJ IntelliJ plugin stale Issues or PRs that are stale (no activity for 30 days) topic: bazel Bazel integration (external repositories, aspects, flags, etc) type: feature request

Comments

@DeCarabas
Copy link

Description of the issue. Please be specific.

We have a number of targets tagged "manual" that we have to irritatingly sync by hand.

I believe these are excluded from the regular sync because the regular sync uses bazel wildcards, and the targets are excluded from the wildcard.

It would be great if the bazel plugin could use bazel query to determine the targets to sync rather than bazel build: this would allow everything to be discovered, and still let us exclude some of our targets from wildcard build and test.

What's the simplest set of steps to reproduce this issue? Please provide an example project, if possible.

  1. Have a project with some manual targets and an extremely minimal project view. (In particular, the project view should reference the manual targets implicitly via wildcard, not explicitly.)
  2. Sync the project.
  3. Note the manual targets are missing.

Version information

IdeaUltimate: 2022.3.1
Platform: Linux 5.19.0-1023-aws
Bazel for IntelliJ plugin: 2023.03.21.0.1-api-version-223
Bazel: 5.3.0

@DeCarabas DeCarabas changed the title Allow synchronization bazel query Allow synchronization via bazel query Apr 25, 2023
@Pavank1992 Pavank1992 added type: feature request product: IntelliJ IntelliJ plugin topic: bazel Bazel integration (external repositories, aspects, flags, etc) os: linux Linux support labels Apr 26, 2023
@mai93
Copy link
Collaborator

mai93 commented May 1, 2023

I think this is similar to #4546. @rogerhu is planning to provide a fix.

@mai93 mai93 added the P3 We're not considering working on this, but happy to review a PR. (No assignee) label May 1, 2023
@mai93 mai93 removed their assignment May 1, 2023
@rogerhu
Copy link
Contributor

rogerhu commented Jul 12, 2023

Sorry for the delay - here is the proposed patch. #5085

Copy link

Thank you for contributing to the IntelliJ repository! This issue has been marked as stale since it has not had any activity in the last 6 months. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-maintainer". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jan 12, 2024
@rogerhu
Copy link
Contributor

rogerhu commented Jan 12, 2024

This ticket i believe can be closed?

@mai93 mai93 closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: linux Linux support P3 We're not considering working on this, but happy to review a PR. (No assignee) product: IntelliJ IntelliJ plugin stale Issues or PRs that are stale (no activity for 30 days) topic: bazel Bazel integration (external repositories, aspects, flags, etc) type: feature request
Projects
Development

No branches or pull requests

4 participants