diff --git a/aswb/src/com/google/idea/blaze/android/run/binary/mobileinstall/MobileInstallBuildStep.java b/aswb/src/com/google/idea/blaze/android/run/binary/mobileinstall/MobileInstallBuildStep.java index 4c8c464eba0..9f2d5cec421 100644 --- a/aswb/src/com/google/idea/blaze/android/run/binary/mobileinstall/MobileInstallBuildStep.java +++ b/aswb/src/com/google/idea/blaze/android/run/binary/mobileinstall/MobileInstallBuildStep.java @@ -155,7 +155,7 @@ public void build(BlazeContext context, BlazeAndroidDeviceSelector.DeviceSession Blaze.getBuildSystemProvider(project) .getBuildSystem() .getBuildInvoker(project, context, BlazeCommandName.MOBILE_INSTALL); - BlazeCommand.Builder command = BlazeCommand.builder(invoker, BlazeCommandName.MOBILE_INSTALL); + BlazeCommand.Builder command = BlazeCommand.builder(invoker, BlazeCommandName.MOBILE_INSTALL, project); if (passAdbArgWithSerialToMi.getValue()) { // Redundant, but we need this to get around bug in bazel. diff --git a/aswb/src/com/google/idea/blaze/android/run/runner/BlazeInstrumentationTestApkBuildStep.java b/aswb/src/com/google/idea/blaze/android/run/runner/BlazeInstrumentationTestApkBuildStep.java index 1537feac26f..f43cae9cb57 100644 --- a/aswb/src/com/google/idea/blaze/android/run/runner/BlazeInstrumentationTestApkBuildStep.java +++ b/aswb/src/com/google/idea/blaze/android/run/runner/BlazeInstrumentationTestApkBuildStep.java @@ -88,7 +88,7 @@ public void build(BlazeContext context, BlazeAndroidDeviceSelector.DeviceSession BuildInvoker invoker = Blaze.getBuildSystemProvider(project).getBuildSystem().getBuildInvoker(project, context); - BlazeCommand.Builder command = BlazeCommand.builder(invoker, BlazeCommandName.BUILD); + BlazeCommand.Builder command = BlazeCommand.builder(invoker, BlazeCommandName.BUILD, project); WorkspaceRoot workspaceRoot = WorkspaceRoot.fromProject(project); // TODO(mathewi) we implicitly rely here on the fact that the getBuildInvoker() call above diff --git a/aswb/src/com/google/idea/blaze/android/run/runner/FullApkBuildStep.java b/aswb/src/com/google/idea/blaze/android/run/runner/FullApkBuildStep.java index ddf257d9f95..bd9d96850e0 100644 --- a/aswb/src/com/google/idea/blaze/android/run/runner/FullApkBuildStep.java +++ b/aswb/src/com/google/idea/blaze/android/run/runner/FullApkBuildStep.java @@ -158,7 +158,7 @@ public void build(BlazeContext context, BlazeAndroidDeviceSelector.DeviceSession BuildInvoker invoker = Blaze.getBuildSystemProvider(project).getBuildSystem().getBuildInvoker(project, context); - BlazeCommand.Builder command = BlazeCommand.builder(invoker, BlazeCommandName.BUILD); + BlazeCommand.Builder command = BlazeCommand.builder(invoker, BlazeCommandName.BUILD, project); WorkspaceRoot workspaceRoot = WorkspaceRoot.fromProject(project); try (BuildResultHelper buildResultHelper = invoker.createBuildResultHelper()) { diff --git a/aswb/src/com/google/idea/blaze/android/run/test/BlazeAndroidTestLaunchTask.java b/aswb/src/com/google/idea/blaze/android/run/test/BlazeAndroidTestLaunchTask.java index dc7dd974c06..d057bc54172 100644 --- a/aswb/src/com/google/idea/blaze/android/run/test/BlazeAndroidTestLaunchTask.java +++ b/aswb/src/com/google/idea/blaze/android/run/test/BlazeAndroidTestLaunchTask.java @@ -157,7 +157,8 @@ public void run(@NotNull BlazeLaunchContext launchContext) Blaze.getBuildSystemProvider(project) .getBuildSystem() .getBuildInvoker(project, context), - BlazeCommandName.TEST) + BlazeCommandName.TEST, + project) .addTargets(target); // Build flags must match BlazeBeforeRunTask. commandBuilder.addBlazeFlags(buildFlags); diff --git a/aswb/tests/unittests/com/google/idea/blaze/android/sync/aspects/strategy/RenderResolveOutputGroupProviderTest.java b/aswb/tests/unittests/com/google/idea/blaze/android/sync/aspects/strategy/RenderResolveOutputGroupProviderTest.java index cc78c525025..e4a0c02f4a3 100644 --- a/aswb/tests/unittests/com/google/idea/blaze/android/sync/aspects/strategy/RenderResolveOutputGroupProviderTest.java +++ b/aswb/tests/unittests/com/google/idea/blaze/android/sync/aspects/strategy/RenderResolveOutputGroupProviderTest.java @@ -111,8 +111,8 @@ public void infoOutputGroups_renderResolveIsNotIncluded() { assertThat(getOutputGroups(builder)).doesNotContain("intellij-render-resolve-android"); } - private static BlazeCommand.Builder emptyBuilder() { - return BlazeCommand.builder("/usr/bin/blaze", BlazeCommandName.BUILD); + private BlazeCommand.Builder emptyBuilder() { + return BlazeCommand.builder("/usr/bin/blaze", BlazeCommandName.BUILD, getProject()); } private static ImmutableList getOutputGroups(BlazeCommand.Builder builder) { diff --git a/base/src/com/google/idea/blaze/base/command/BlazeCommand.java b/base/src/com/google/idea/blaze/base/command/BlazeCommand.java index 5d7cf03d253..d2c0b68c9e8 100644 --- a/base/src/com/google/idea/blaze/base/command/BlazeCommand.java +++ b/base/src/com/google/idea/blaze/base/command/BlazeCommand.java @@ -21,6 +21,7 @@ import com.google.idea.blaze.base.bazel.BuildSystem.BuildInvoker; import com.google.idea.blaze.base.model.primitives.TargetExpression; import com.google.idea.blaze.base.sync.aspects.strategy.AspectRepositoryProvider; +import com.intellij.openapi.project.Project; import java.nio.file.Path; import java.util.Arrays; @@ -81,16 +82,16 @@ public String toString() { return Joiner.on(' ').join(toList()); } - public static Builder builder(BuildInvoker invoker, BlazeCommandName name) { - return new Builder(invoker.getBinaryPath(), name); + public static Builder builder(BuildInvoker invoker, BlazeCommandName name, Project project) { + return new Builder(invoker.getBinaryPath(), name, project); } /** * @deprecated Use {@link #builder(BuildInvoker, BlazeCommandName)} instead. */ @Deprecated - public static Builder builder(String binaryPath, BlazeCommandName name) { - return new Builder(binaryPath, name); + public static Builder builder(String binaryPath, BlazeCommandName name, Project project) { + return new Builder(binaryPath, name, project); } /** Builder for a blaze command */ @@ -104,14 +105,14 @@ public static class Builder { private final ImmutableList.Builder blazeCmdlineFlags = ImmutableList.builder(); private final ImmutableList.Builder exeFlags = ImmutableList.builder(); - public Builder(String binaryPath, BlazeCommandName name) { + public Builder(String binaryPath, BlazeCommandName name, Project project) { this.binaryPath = binaryPath; this.name = name; this.invokeParallel = false; // Tell forge what tool we used to call blaze so we can track usage. addBlazeFlags(BlazeFlags.getToolTagFlag()); - AspectRepositoryProvider.getOverrideFlag().ifPresent(this::addBlazeFlags); + AspectRepositoryProvider.getOverrideFlag(project).ifPresent(this::addBlazeFlags); } private ImmutableList getArguments() { diff --git a/base/src/com/google/idea/blaze/base/command/info/BlazeInfoRunnerImpl.java b/base/src/com/google/idea/blaze/base/command/info/BlazeInfoRunnerImpl.java index f87c9d6c1a3..ca112e5990a 100644 --- a/base/src/com/google/idea/blaze/base/command/info/BlazeInfoRunnerImpl.java +++ b/base/src/com/google/idea/blaze/base/command/info/BlazeInfoRunnerImpl.java @@ -42,7 +42,7 @@ public ListenableFuture runBlazeInfoGetBytes( return BlazeExecutor.getInstance() .submit( () -> { - BlazeCommand.Builder builder = BlazeCommand.builder(invoker, BlazeCommandName.INFO); + BlazeCommand.Builder builder = BlazeCommand.builder(invoker, BlazeCommandName.INFO, project); builder.addBlazeFlags(blazeFlags); if (keys != null) { builder.addBlazeFlags(keys); diff --git a/base/src/com/google/idea/blaze/base/command/mod/BlazeModRunnerImpl.java b/base/src/com/google/idea/blaze/base/command/mod/BlazeModRunnerImpl.java index 433f0de51f8..d0dc59481ab 100644 --- a/base/src/com/google/idea/blaze/base/command/mod/BlazeModRunnerImpl.java +++ b/base/src/com/google/idea/blaze/base/command/mod/BlazeModRunnerImpl.java @@ -114,7 +114,7 @@ protected ListenableFuture runBlazeModGetBytes( .submit( () -> { BlazeCommand.Builder builder = - BlazeCommand.builder(invoker, BlazeCommandName.MOD).addBlazeFlags(flags); + BlazeCommand.builder(invoker, BlazeCommandName.MOD, project).addBlazeFlags(flags); if (args != null) { builder.addBlazeFlags(args); diff --git a/base/src/com/google/idea/blaze/base/dependencies/BlazeQueryDirectoryToTargetProvider.java b/base/src/com/google/idea/blaze/base/dependencies/BlazeQueryDirectoryToTargetProvider.java index 3106f05e9a0..a6747546383 100644 --- a/base/src/com/google/idea/blaze/base/dependencies/BlazeQueryDirectoryToTargetProvider.java +++ b/base/src/com/google/idea/blaze/base/dependencies/BlazeQueryDirectoryToTargetProvider.java @@ -99,7 +99,7 @@ private static ImmutableList runQuery( BuildSystem buildSystem = Blaze.getBuildSystemProvider(project).getBuildSystem(); BlazeCommand.Builder command = BlazeCommand.builder( - buildSystem.getDefaultInvoker(project, context), BlazeCommandName.QUERY) + buildSystem.getDefaultInvoker(project, context), BlazeCommandName.QUERY, project) .addBlazeFlags("--output=label_kind") .addBlazeFlags("--keep_going") .addBlazeFlags(query); diff --git a/base/src/com/google/idea/blaze/base/dependencies/BlazeQuerySourceToTargetProvider.java b/base/src/com/google/idea/blaze/base/dependencies/BlazeQuerySourceToTargetProvider.java index 32bf0d244ac..fc2ce7e232e 100644 --- a/base/src/com/google/idea/blaze/base/dependencies/BlazeQuerySourceToTargetProvider.java +++ b/base/src/com/google/idea/blaze/base/dependencies/BlazeQuerySourceToTargetProvider.java @@ -291,7 +291,7 @@ private static BlazeCommand.Builder getBlazeCommandBuilder( : BlazeQueryOutputBaseProvider.getInstance(project).getOutputBaseFlag(); BuildInvoker buildInvoker = Blaze.getBuildSystemProvider(project).getBuildSystem().getDefaultInvoker(project, context); - return BlazeCommand.builder(buildInvoker, BlazeCommandName.QUERY) + return BlazeCommand.builder(buildInvoker, BlazeCommandName.QUERY, project) .addBlazeFlags(additionalBlazeFlags) .addBlazeFlags("--keep_going") .addBlazeFlags(query) diff --git a/base/src/com/google/idea/blaze/base/qsync/BazelAppInspectorBuilder.java b/base/src/com/google/idea/blaze/base/qsync/BazelAppInspectorBuilder.java index 578042c5bc5..76fb253f2b2 100644 --- a/base/src/com/google/idea/blaze/base/qsync/BazelAppInspectorBuilder.java +++ b/base/src/com/google/idea/blaze/base/qsync/BazelAppInspectorBuilder.java @@ -65,7 +65,7 @@ public AppInspectorInfo buildAppInspector(BlazeContext context, Set