From 0f056b51eeae683a144b2d1fc64a10819212172d Mon Sep 17 00:00:00 2001 From: Tony Aiuto Date: Tue, 8 Nov 2022 23:48:32 -0500 Subject: [PATCH] comments --- cpu/BUILD | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/cpu/BUILD b/cpu/BUILD index 85df4b9..b01dbd0 100644 --- a/cpu/BUILD +++ b/cpu/BUILD @@ -13,6 +13,24 @@ filegroup( # To add a new constraint_value see https://github.com/bazelbuild/platforms. constraint_setting(name = "cpu") +# New cpu values should refer to specific, highly available CPU implementations, +# not broad architectures. It should be possible to select the right compiler +# options by just by knowing the cpu. This can be a difficult evaluation for +# ARM variations, where there are many possibilities for customization within +# an architecture. +# +# 1. No private names are be allowed. If you build your own custom ARM chips, +# then define them locally within your organization. +# 2. All CPU values must be clear that they are for a 32 or a 64 bit +# implementation. For example, cortex-r52 is a 32 bit processor, and +# cortex-r82 is a 64 bit processor, but both are armv8-r architecture. +# We use the specific processor names because armv8-r is insufficient to +# select proper compiler options. +# +# Many of the name here are legacy values and probably violate these conditions. +# We'll try to clean those up over time. + + # TODO(b/136237408): Remove this generic CPU name and replace with a specific one. alias( name = "aarch64",