-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discussion] Deprecate //cpu:armv8-m
in favor of //cpu:armv8-m.main
#104
Comments
Perhaps there's an argument to be made that we should just jump ship entirely on this expression, and use the names available for |
It looks like @aiuto already clarified that we should be using the CPU type itself (rather than ISA) moving forward: 0f056b5 For now, I think the answer is to pivot to adding:
And then mark the Note that for reasons being discussed in #100, no FPU nuances will be represented in these CPU types. |
I'm debating the value of converting the old variants to If we do aliases, we should probably map it like this:
|
Similar to #100, I'm looking to tidy up some pre-existing Cortex-M CPU expressions here.
Proposal
Mark
//cpu:armv8-m
as deprecated, and introduce//cpu:armv8-m.base
and//cpu:armv8-m.main
.Why?
ARMv8-M is technically split into two distinctly different ISAs:
armv8-m.main
andarmv8-m.base
. The baseline variant of ARMv8-M is more akin toARMv6-M
thanARMv7E-M
. Also, when spelling-march
, there is no such option forarmv8-m
. The flavors are eitherarmv8-m.base
orarmv8-m.main
. Note that these flavors are not traditionally considered extensions (unlike FPU or DSP instructions).Also, this naming carries forward with the
armv8.1-m.main
architecture, even though it doesn't have aarmv8.1-m.base
variant.The text was updated successfully, but these errors were encountered: