Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository @rules_license is not defined #66

Open
oliverlee opened this issue Apr 27, 2023 · 4 comments
Open

Repository @rules_license is not defined #66

oliverlee opened this issue Apr 27, 2023 · 4 comments

Comments

@oliverlee
Copy link

I'm not using bzlmod so I'm getting an error due to not defining rules_license in my WORKSPACE file and a recent commit of this repo and use of @platforms//:incompatible. Should there be a dependencies macro as mentioned here or is bzlmod the only way going forward?

@aiuto
Copy link
Contributor

aiuto commented May 8, 2023

Yes. I see this repository does not have a deps.bzl pattern.
Rather than adding that piece of ugly. I'll update the release notes to include the a pointer to the workspace stanza for rules_license.

@aiuto
Copy link
Contributor

aiuto commented May 8, 2023

Currently that would be.

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_license",
    urls = [
        "https://github.com/bazelbuild/rules_license/releases/download/0.0.4/rules_license-0.0.4.tar.gz",
        "https://mirror.bazel.build/github.com/bazelbuild/rules_license/releases/download/0.0.4/rules_license-0.0.4.tar.gz",
    ],
    sha256 = "6157e1e68378532d0241ecd15d3c45f6e5cfd98fc10846045509fb2a7cc9e381",
)

@fmeum
Copy link
Contributor

fmeum commented Aug 28, 2023

@aiuto The notes for the current release do not have this stanza in the release notes.

I would go as far as saying that a repo that is as fundamental as @platforms should not have any dependencies, at least not in a WORKSPACE world. Could the rules_license dep be moved to a subpackage that isn't part of the API of @platforms?

@jwnimmer-tri
Copy link

... should not have any dependencies ...

As a user, I would prefer this. However, in the meantime ...

... the notes for the current release do not have this stanza in the release notes ...

... we should at least document the status quo. I've filed #82 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants