Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support resumable uploads #204

Open
ola-rozenfeld opened this issue Oct 9, 2020 · 1 comment
Open

Support resumable uploads #204

ola-rozenfeld opened this issue Oct 9, 2020 · 1 comment
Assignees
@ola-rozenfeld
Labels
category: performance performance improvement lang: go type: feature request

Comments

@ola-rozenfeld
Copy link
Contributor

When we retry a failed Write call, we should respect the committed_bytes returned by the server and not redo everything from scratch, saving time and bandwidth.
@ola-rozenfeld ola-rozenfeld self-assigned this Oct 9, 2020
@ola-rozenfeld ola-rozenfeld mentioned this issue Oct 15, 2020
Closed
@ola-rozenfeld
Copy link
Contributor Author

Actually, this won't be as easy, because RBE doesn't support resumable uploads yet, and I'm not sure on the state of other clients. We may need to either catch the Unimplemented error from the server if these are not supported, or consider adding it to Capabilities (I prefer the former).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ola-rozenfeld ola-rozenfeld

Labels
category: performance performance improvement lang: go type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ola-rozenfeld