From 36dc1852746ead43dd6abc829738f9a16515345c Mon Sep 17 00:00:00 2001 From: Mostyn Bramley-Moore Date: Tue, 24 Nov 2020 23:24:51 +0100 Subject: [PATCH] fixup! Add support for transferring compressed blobs via ByteStream Add a note about ReadRequest.read_limit referring to the compressed data and warning clients not to assume that this value is <= the uncompressed data size. --- build/bazel/remote/execution/v2/remote_execution.proto | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/build/bazel/remote/execution/v2/remote_execution.proto b/build/bazel/remote/execution/v2/remote_execution.proto index 235e3da6..22c382ff 100644 --- a/build/bazel/remote/execution/v2/remote_execution.proto +++ b/build/bazel/remote/execution/v2/remote_execution.proto @@ -281,7 +281,10 @@ service ActionCache { // surfacing an error to the user. // // Note that when reading compressed blobs, the `ReadRequest.read_offset` -// refers to the offset in the uncompressed form of the blob. +// refers to the offset in the uncompressed form of the blob, and the +// `ReadRequest.read_limit` refers to the offset in the specific compressed +// form that the server provides. Clients SHOULD NOT assume that the compressed +// form is the same or smaller size than the uncompressed form. // // Servers MAY use any compression level they choose, including different // levels for different blobs (e.g. choosing a level designed for maximum