Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel 7: Linking actions missing-framework flags for framework imports #2427

Closed
chiragramani opened this issue Mar 9, 2024 · 2 comments
Closed

Comments

@chiragramani
Copy link
Contributor

Repro:
bazel aquery //examples/ios/HelloWorldSwift:UnitTests.__internal__.__test_bundle
rules_apple-master 2.zip

-Fexamples/ios/HelloWorldSwift/ExampleFramework.xcframework/ios-arm64_x86_64-simulator \
-framework \
Lottie \

is present when building with Bazel 6.x.x but not present with Bazel 7.x.x(tested on Bazel 7.1.0rc2).

The builds are successfully finishing, but I'm uncertain whether this is the anticipated behavior. Could any adjustments be required, considering this might be linked to bazelbuild/bazel#19000?

bazel6aquery.txt
bazel7aquery.txt

@brentleyjones
Copy link
Collaborator

This is expected as part of the migration away from ObjCProvider. The executables of frameworks are listed directly in the linkopts now (you might notice they use the mangled form as well).

@chiragramani
Copy link
Contributor Author

This makes sense. Appreciate you looking into it @brentleyjones. I am closing this as it's not an issue.

@brentleyjones brentleyjones closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants