Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto libraries with dependencies #190

Closed
wiktortomczak opened this issue Mar 18, 2017 · 3 comments
Closed

Proto libraries with dependencies #190

wiktortomczak opened this issue Mar 18, 2017 · 3 comments

Comments

@wiktortomczak
Copy link

wiktortomczak commented Mar 18, 2017

Is there a way to generate a JS proto library from a .proto file with dependencies (on other .proto files that the top-level .proto imports) ? IIUC closure_js_proto_library does not support a deps= argument. I suppose it could?

I believe the implementation of closure_js_proto_library(deps=...) could rely on the proto_library rule added to Bazel recently.

@rohanag12
Copy link

Is there any plan on supporting this feature? Also, is there some workaround we can use for this (other than bundling statically generated files, of course)?

@shubhangitaneja
Copy link

Ability to specify deps in closure_js_proto_library would be definitely helpful. My proto is importing "google/protobuf/timestamp.proto" and right now I don't see any way to specify a dependency on it.

@pshields
Copy link

pshields commented Jan 1, 2018

I've run into a similar issue. The protos I'm compiling import google/api/annotations.proto. I tried adding that file and its deps as a filegroup passed to srcs (in addition to my regular srcs), but ran into additional errors. I think being able to specify deps via a deps parameter would help. At the very least, it would be more idiomatic.

Incidentally, if I strip out my google/api/annotations.proto import and related code, my closure_js_proto_library rule is able to build successfully and is able to resolve my google/protobuf/timestamp.proto imports.

Yannic added a commit to Yannic/rules_closure that referenced this issue Apr 12, 2018
@jart jart closed this as completed in #263 Apr 13, 2018
jart pushed a commit that referenced this issue Apr 13, 2018
ptmphuong pushed a commit to ptmphuong/rules_closure that referenced this issue Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants