Use standard Bazel proto toolchain #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, @com_google_protobuf_java is defined by the protobuf-java jars published on Maven Central, imported into rules_closure by the java_import_external() Skylark rule. Meanwhile, the protobuf repository is a Bazel repository. Its //:protobuf_java target provides the same functionality as the protobuf-java jars. Importing the protobuf repo via http_archive is the officially recommended way of using protos in Bazel (https://blog.bazel.build/2017/02/27/protocol-buffers.html). This commit changes the definition of rules_closure's @com_google_protobuf_java from the maven jar-based approach to a real http_archive. This will allow downstream repos that currently have the recommended proto setup to use rules_closure.
Bazel has shipped with a java_proto_library rule since 0.4.5 (March 2017). It is the officially recommended way to use protos with Java (https://blog.bazel.build/2017/02/27/protocol-buffers.html). Meanwhile, rules_closure has had a private java_proto_library macro since mid-2016. The provenance of this macro is unclear (the commit adding it, 9dd5f9, doesn't explain where it came from), but based on the copyright notice at the top of the file, it was probably forked from the Bazel repo before the native java_proto_library was publicly available. There don't seem to be any advantages for rules_closure to continue maintaining its idiosyncratic proto rules. This commit therefore removes java_proto_library.bzl and changes all java_proto_library targets in the repo to conform to the official API.
Currently, rules_closure has special logic for downloading and invoking the protoc binary. The protobuf repository also exposes a Bazel target for protoc (@com_google_protobuf//:protoc), which is the recommended way of invoking protoc from Bazel. This commit changes rules_closure and its one proto rule (closure_js_proto_library) to use the standard protoc toolchain. As a result, the special logic for dealing directly with protoc can be removed.
|
Can one of the admins verify this patch? |
Ubehebe
commented
Nov 27, 2017
| sha256 = "0cc6607e2daa675101e9b7398a436f09167dffb8ca0489b0307ff7260498c13c", | ||
| strip_prefix = "protobuf-3.5.0", | ||
| urls = [ | ||
| "https://mirror.bazel.build/github.com/google/protobuf/archive/v3.5.0.tar.gz", |
There was a problem hiding this comment.
This bumps the protoc version from 3.3 to 3.5. (Because of some changes in the JSPB runtime, this requires a similar bump to com_google_protobuf_js below.) If you prefer, I can stick with 3.3 in this PR and bump the versions later.
|
Could you please send this as an internal CL? Otherwise I'll have to patch this by hand into the internal repo and re-export it. |
jart
pushed a commit
that referenced
this pull request
Jan 12, 2018
This CL switches rules_closure to use Bazel's built-in java_proto_library rule instead of a custom Skylark rule. It also switches the protoc binary to the standard @com_google_protobuf//:protoc instead of a custom-downloaded dependency. This CL is a port that fixes #231 and #232. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=177367734
ptmphuong
pushed a commit
to ptmphuong/rules_closure
that referenced
this pull request
Dec 9, 2022
This CL switches rules_closure to use Bazel's built-in java_proto_library rule instead of a custom Skylark rule. It also switches the protoc binary to the standard @com_google_protobuf//:protoc instead of a custom-downloaded dependency. This CL is a port that fixes bazelbuild#231 and bazelbuild#232. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=177367734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches rules_closure to use Bazel's built-in java_proto_library rule instead of a custom Skylark rule. It also switches the protoc binary to the standard @com_google_protobuf//:protoc instead of a custom-downloaded dependency. See the commit descriptions for more details.
(Note that 73e9f1d is part of a separate PR, so that diff should disappear from this PR once it is merged.)