Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all tests passing with --incompatible_disable_legacy_cc_provider for Bazel 0.25.0 #22

Closed
oquenchil opened this issue Mar 5, 2019 · 0 comments

Comments

@oquenchil
Copy link

It seems that rules_d will start breaking with the next Bazel release 0.25 because of an incompatible change (bazelbuild/bazel#7036)

ERROR: /Users/buildkite/builds/buildkite-imacpro-2/bazel-downstream-projects/rules_d/examples/hello_lib/BUILD:22:1: in d_source_library rule //examples/hello_lib:native_greeter:
  | Traceback (most recent call last):
  | File "/Users/buildkite/builds/buildkite-imacpro-2/bazel-downstream-projects/rules_d/examples/hello_lib/BUILD", line 22
  | d_source_library(name = 'native_greeter')
  | File "/Users/buildkite/builds/buildkite-imacpro-2/bazel-downstream-projects/rules_d/d/d.bzl", line 356, in _d_source_library_impl
  | fail("d_source_library can only depen...", ...")

https://github.com/bazelbuild/rules_d/blob/master/d/d.bzl is using hasattr(dep, "cc") instead the new provider should be used as described in the link above. For example, to check if the dependency has the provider it should be CcInfo in dep
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant